From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-32814-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 19929 invoked by alias); 4 May 2004 15:20:25 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 19879 invoked from network); 4 May 2004 15:20:23 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 4 May 2004 15:20:23 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i44FKNkG026900
	for <gdb-patches@sources.redhat.com>; Tue, 4 May 2004 11:20:23 -0400
Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i44FKLv10171;
	Tue, 4 May 2004 11:20:22 -0400
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: let gdbarch define FP0_REGNUM on rs6000
References: <vt2ad0phxz0.fsf@zenia.home> <4097A012.2050409@gnu.org>
From: Jim Blandy <jimb@redhat.com>
Date: Tue, 04 May 2004 15:20:00 -0000
In-Reply-To: <4097A012.2050409@gnu.org>
Message-ID: <vt27jvs5ik6.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-05/txt/msg00101.txt.bz2

Andrew Cagney <cagney@gnu.org> writes:

> > 2004-05-03  Jim Blandy  <jimb@redhat.com>
> > 	* config/rs6000/tm-rs6000.h (FP0_REGNUM): Delete.  Let
> > gdbarch.h
> > 	define this.
> > 	* rs6000-tdep.c (rs6000_gdbarch_init): Set gdbarch_fp0_regnum.
> > diff -cr src.no-gplast-fplast/gdb/config/rs6000/tm-rs6000.h
> > src/gdb/config/rs6000/tm-rs6000.h
> > *** gdb/config/rs6000/tm-rs6000.h	2004-05-03 17:32:42.000000000 -0500
> > --- gdb/config/rs6000/tm-rs6000.h	2004-05-03 17:39:34.000000000 -0500
> > ***************
> > *** 64,78 ****
> >   #define	PROCESS_LINENUMBER_HOOK()	aix_process_linenos ()
> >   extern void aix_process_linenos (void);
> >   - /* Register numbers of various important registers.
> > -    Note that some of these values are "real" register numbers,
> > -    and correspond to the general registers of the machine,
> > -    and some are "phony" register numbers which are too large
> > -    to be actual register numbers as far as the user is concerned
> > -    but do serve to get the desired values when passed to read_register.  */
> > -
> > - #define FP0_REGNUM 32		/* Floating point register 0 */
> 
> Note that FP0_REGNUM is on the deprecate hit list, it's superseeded by
> things like reggroups and regsets.  As with other code, you should
> s/FP0_REGNUM/RS6000_FP0_REGNUM/ where possible.

Okay.  In the RS6000 case, it'd probably be more consistent to simply
use tdep->ppc_fp0_regnum, rather than introducing a new macro.