From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19731 invoked by alias); 18 Jun 2004 22:20:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19724 invoked from network); 18 Jun 2004 22:20:30 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 18 Jun 2004 22:20:30 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i5IMKUe3031904 for ; Fri, 18 Jun 2004 18:20:30 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i5IMKR023238; Fri, 18 Jun 2004 18:20:27 -0400 To: Daniel Jacobowitz Cc: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com, Keith Seitz , Andrew Cagney Subject: Re: RFA: patch to fix gdb/1680 References: <20040618191836.629204B104@berman.michael-chastain.com> <20040618194250.GA28102@nevyn.them.org> From: Jim Blandy Date: Fri, 18 Jun 2004 22:20:00 -0000 In-Reply-To: <20040618194250.GA28102@nevyn.them.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-06/txt/msg00451.txt.bz2 Daniel Jacobowitz writes: > On Fri, Jun 18, 2004 at 03:18:36PM -0400, Michael Chastain wrote: > > drow> Does it work if you put a backslash in front of them instead? That's > > drow> clearer to read, IMO. > > > > On my machine (expect 5.41): > > > > "{...}" ERROR: Process no longer exists > > "\{...\}" ERROR: Process no longer exists > > "\\{...\\}" Works fine > > This error means that, somewhere, a syntax error has occured and > dejagnu has swallowed it. I submitted a patch to DejaGNU to diagnose > this better and it was ignored in the general confusion that is DejaGNU > maintenance. > > > I definitely want Jim's patch so that i386-sse.exp does its job. > > If you insist, we could make PR gdb/1680 suspended instead of > > closing it, to remind us of this unsolved mystery. > > I prefer to solve the mystery instead. > > If you pull that patch out of the DejaGNU list archives and apply it, > you will see: > ERROR OCCURED: couldn't compile regular expression pattern: invalid repetition count(s) > > Presumably this version of TCL does not put special meaning on > {string}, but does on {NUMBER}, as has become fashionable for regex > engines. When it sees {stringStartingWithADigit}, it tries to parse it > as a repetition count and throws an error. Ahh. Here is a revision of my patch. It is tested under the same configuration as the original patch. 2004-06-17 Jim Blandy Fix PR testsuite/1680. * gdb.arch/i386-sse.exp: Don't use curly braces in regular expressions. Index: gdb/testsuite/gdb.arch/i386-sse.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-sse.exp,v retrieving revision 1.1 diff -c -p -r1.1 i386-sse.exp *** gdb/testsuite/gdb.arch/i386-sse.exp 7 Jun 2004 15:38:52 -0000 1.1 --- gdb/testsuite/gdb.arch/i386-sse.exp 18 Jun 2004 22:15:52 -0000 *************** gdb_continue_to_breakpoint "continue to *** 71,77 **** foreach r {0 1 2 3 4 5 6 7} { gdb_test "print \$xmm$r.v4_float" \ ! ".. = {$r, $r.25, $r.5, $r.75}.*" \ "check contents of %xmm$r" } --- 71,77 ---- foreach r {0 1 2 3 4 5 6 7} { gdb_test "print \$xmm$r.v4_float" \ ! ".. = \\{$r, $r.25, $r.5, $r.75\\}.*" \ "check contents of %xmm$r" } *************** gdb_continue_to_breakpoint "continue to *** 86,91 **** foreach r {0 1 2 3 4 5 6 7} { gdb_test "print data\[$r\]" \ ! ".. = {f = {[expr $r + 10], $r.25, $r.5, $r.75}}.*" \ "check contents of data\[$r\]" } --- 86,91 ---- foreach r {0 1 2 3 4 5 6 7} { gdb_test "print data\[$r\]" \ ! ".. = \\{f = \\{[expr $r + 10], $r.25, $r.5, $r.75\\}\\}.*" \ "check contents of data\[$r\]" }