Re: [Jim Blandy <jimb@redhat.com>] RFA: testsuite: pass optimization flag in the proper way

[Jim Blandy <jimb@redhat.com>]

Fernando Nasser <fnasser@redhat.com> writes:

>  > !     # Why do we need to specify '-O1' here?  Shouldn't that sort of
>  > !     # compilation parameter be under the control of the test framework
>  > !     # (the target_list and so on)?
> 
> Because you would be changing it for all tests while this test seems
> to require a specific setting.for some reason.
> 
> This part is approved:
> 
>  > !     if { [gdb_compile "$srcdir/$subdir/$srcfile" "$binfile" \
>  > ! 	    executable {debug additional_flags=-w optimize=-O1}] != "" } {
> 
> The comment could be:
> 
> "Why do we need this specific optimization level here?"
> 
> or the answer to this question if you know why.

Okay, thanks.  I've committed the following:

2002-12-22  Jim Blandy  <jimb@redhat.com>

	* gdb.trace/tfind.exp: Pass '-O1' flag via the 'optimize' option,
	rather than as part of the output file name.

Index: gdb/testsuite/gdb.trace/tfind.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.trace/tfind.exp,v
retrieving revision 1.2
diff -c -r1.2 tfind.exp
*** gdb/testsuite/gdb.trace/tfind.exp	6 Mar 2001 08:22:00 -0000	1.2
--- gdb/testsuite/gdb.trace/tfind.exp	22 Dec 2002 23:58:33 -0000
***************
*** 53,60 ****
      set testfile "actions"
      set srcfile ${testfile}.c
      set binfile $objdir/$subdir/$testfile
!     if { [gdb_compile "$srcdir/$subdir/$srcfile" "$binfile -O1" \
! 	    executable {debug additional_flags=-w}] != "" } {
  	gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
      }
      gdb_load $binfile
--- 53,65 ----
      set testfile "actions"
      set srcfile ${testfile}.c
      set binfile $objdir/$subdir/$testfile
! 
!     # Why does this test require '-O1' level optimization?  (In
!     # general, the optimization level should be left under the control
!     # of the test framework (target_list and so on), so if we don't
!     # have to override it in individual tests like this, we shouldn't.)
!     if { [gdb_compile "$srcdir/$subdir/$srcfile" "$binfile" \
! 	    executable {debug additional_flags=-w optimize=-O1}] != "" } {
  	gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
      }
      gdb_load $binfile