From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11970 invoked by alias); 7 Oct 2003 21:42:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11960 invoked from network); 7 Oct 2003 21:42:55 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 7 Oct 2003 21:42:55 -0000 Received: by zenia.home (Postfix, from userid 5433) id 27A8F20766; Tue, 7 Oct 2003 16:41:35 -0500 (EST) To: gdb-patches@sources.redhat.com Subject: RFC: Use program_transform_name correctly From: Jim Blandy Date: Tue, 07 Oct 2003 21:42:00 -0000 Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-10/txt/msg00171.txt.bz2 It seems as if some Makefiles aren't properly using program_transform_name. The same kind of weirdness corrected(?) in the patch below appears in gdb/Makefile.in, so I'm not at all sure I'm not misunderstanding what's going on. If folks agree that the change below would be correct, then I'll put together a larger patch that fixes the ones I can find elsewhere, too. (Not sure why this hasn't come up before; Daniel J.'s recent posts on the topic seem to be about setting program_transform_name, not on how to use it.) 2003-10-07 Jim Blandy * Makefile.in (RUNTEST_FOR_TARGET): Pass the transformation to set properly. Index: gdb/testsuite//Makefile.in =================================================================== RCS file: /cvs/cvsfiles/devo/gdb/testsuite/Makefile.in,v retrieving revision 1.66 diff -c -r1.66 Makefile.in *** gdb/testsuite//Makefile.in 9 Sep 2003 21:03:53 -0000 1.66 --- gdb/testsuite//Makefile.in 7 Oct 2003 21:33:22 -0000 *************** *** 53,59 **** if [ "$(host_canonical)" = "$(target_canonical)" ]; then \ echo runtest; \ else \ ! t='$(program_transform_name)'; echo runtest | sed -e '' $$t; \ fi; \ fi` --- 53,59 ---- if [ "$(host_canonical)" = "$(target_canonical)" ]; then \ echo runtest; \ else \ ! t='$(program_transform_name)'; echo runtest | sed -e '$$t'; \ fi; \ fi`