From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3895 invoked by alias); 8 Apr 2004 22:13:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3881 invoked from network); 8 Apr 2004 22:13:00 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 8 Apr 2004 22:13:00 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i38MCxMC009353 for ; Thu, 8 Apr 2004 18:12:59 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i38MCwj28314; Thu, 8 Apr 2004 18:12:58 -0400 To: Roland McGrath Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] add-symbol-file-from-memory command References: <200404082047.i38Klcqb010158@magilla.sf.frob.com> From: Jim Blandy Date: Thu, 08 Apr 2004 22:13:00 -0000 In-Reply-To: <200404082047.i38Klcqb010158@magilla.sf.frob.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-04/txt/msg00197.txt.bz2 Roland McGrath writes: > I updated my tree and made a new diff for add-symbol-file-from-memory, > though there were no conflicts to resolve so it's not materially different > >From the last version of this patch I posted. It still works with today's > gdb. Several people have looked at this code before. It just needs > authoritative approval to go in. If anyone has any reservations, I haven't > heard them articulated. As I've mentioned before, the new command itself > is not the motivation for the new function. It's the final piece of > necessary infrastructure for vsyscall DSO support for Linux targets. > (After this, the only thing needed is the glue to check for AT_SYSINFO at > the right time.) This looks fine. Two suggestions: - Would it work to completely replace symbol_file_add_with_addrs_or_offsets's 'name' argument with the abfd argument, and then just use bfd_get_filename? It looks to me like the only affect would be that the tilde-expanded, path-searched filename would appear in messages, which seems like a good thing. - Since the command isn't something that ordinary users are really going to want themselves, but is more for the benefit of GDB developers, should be a 'maint' subcommand?