From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32139 invoked by alias); 8 May 2006 17:47:32 -0000 Received: (qmail 32131 invoked by uid 22791); 8 May 2006 17:47:32 -0000 X-Spam-Check-By: sourceware.org Received: from intranet.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.6) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 08 May 2006 17:47:31 +0000 Received: (qmail 13682 invoked from network); 8 May 2006 17:47:29 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 May 2006 17:47:29 -0000 To: Gaius Mulley Cc: "Eli Zaretskii" , gdb-patches@sources.redhat.com Subject: Re: Enhanced language support for Modula-2 References: <87psjc9yu3.fsf@glam.ac.uk> <87psius247.fsf@glam.ac.uk> <20060504153726.GA2396@nevyn.them.org> <8f2776cb0605041101u7d969e0eodde33866ac4abc41@mail.gmail.com> <874q00liyr.fsf@glam.ac.uk> From: Jim Blandy Date: Mon, 08 May 2006 17:47:00 -0000 In-Reply-To: <874q00liyr.fsf@glam.ac.uk> (Gaius Mulley's message of "08 May 2006 14:55:08 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00156.txt.bz2 Gaius Mulley writes: > "Jim Blandy" writes: > >> The revised patch looks fine. The only question I have is, what's up >> with m2_type_print_base? Is that the way it's supposed to be? > > Hi, > > thanks for the feedback and here is the revised patch - which fixes > the documentation: > > @example -> @smallexample > @end example -> @end smallexample > and uses the American spelling of `recogni[sz]ed'. > > and the code change removes the function m2_type_print_base and > substitutes the call to it by a call to m2_print_type instead. Okay, just some fine-toothed comb stuff: Have you written ChangeLog entries for this? Follow the format the other entries use. In GDB code, each curly brace gets a line to itself. I see a few sharing a line with an 'if' or 'else' in m2-valprint.c and m2-typeprint.c. Also, all GNU code should fit in eighty columns. I see some indentation problems in m2_val_print. If you're using GNU Emacs, just hit M-C-q before the function's opening brace, and it'll take care of it.