From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31806 invoked by alias); 10 Sep 2003 17:31:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31799 invoked from network); 10 Sep 2003 17:31:57 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 10 Sep 2003 17:31:57 -0000 Received: by zenia.home (Postfix, from userid 5433) id C564720508; Wed, 10 Sep 2003 12:30:18 -0500 (EST) To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] parse and eval breakpoint conditions with correct language References: <20030910015400.GS423@gnat.com> From: Jim Blandy Date: Wed, 10 Sep 2003 17:31:00 -0000 In-Reply-To: <20030910015400.GS423@gnat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-09/txt/msg00199.txt.bz2 Joel Brobecker writes: > This RFA is a followup on the thread started on gdb@: > > http://sources.redhat.com/ml/gdb/2003-09/msg00082.html > > I incorporated Jim's comments (set expout->language_defn, handle > NULL expression_context_block). There was also another gotcha > that the testsuite detected which is to handle the cases when > the context block language is not null, but the unknown language. > > 2003-09-09 J. Brobecker > > * parse.c (parse_exp_1): Use the language associated to > the context block when parsing an expression. > > Tested on x86-linux. > > Ok to apply? Looks good to me, definitely a step forward.