Re: Variable objects: references formatting

Vladimir Prus
2006-05-04T05:19:05Z

On Wednesday 03 May 2006 22:08, Jim Blandy wrote:
> On 5/3/06, Jim Blandy <jimb@red-bean.com> wrote:
> > On 5/3/06, Vladimir Prus <ghost@cs.msu.su> wrote:
> > > At the moment, when using variable objects to display a struct or a
> > > class, the result of -data-evaluate-expression is "...". However, when
> > > displaying a reference to a class, the result of
> > > -data-evaluate-expression is {}-enclosed list of members and their
> > > values.
> > >
> > > This disparity does not seem to be reasonable, the attached patch fixes
> > > it:
> >
> > I think you're right, and the patch looks good. I'll apply it.
>
> Some further stuff I came across, for future reference:
>
> - ChangeLog entries need to have two spaces between the date and the
> name, and the name and the email address.

Did you know about this rule, will use it in future.

> They need an asterisk
> before the filename. Check out the other ChangeLog entries for
> examples.

That's just a typo.

> - When declaring a pointer to a type, GNU coding style writes 'type
> *ptr', not 'type* ptr'.

Oh, sorry, C++ habits. Will try to avoid it.

> - In GDB, when traversing types, remember to call check_typedef to
> avoid having your traversal stopped by typedef nodes.

Thanks, noted. So, in this case I should have called check_typedef before
checking if type is reference, right?

Would you like me to resend the patch adjusted per your comments, or you've
already done those changes locally?

Thanks,
Volodya