From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15791 invoked by alias); 5 May 2006 08:08:32 -0000 Received: (qmail 15779 invoked by uid 22791); 5 May 2006 08:08:31 -0000 X-Spam-Check-By: sourceware.org Received: from intranet.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.6) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 May 2006 08:08:28 +0000 Received: (qmail 5814 invoked from network); 5 May 2006 08:08:26 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 May 2006 08:08:26 -0000 To: Nick Roberts Cc: "Vladimir Prus" , gdb-patches@sources.redhat.com Subject: Re: Variable objects: references formatting References: <17497.14121.225320.477428@farnswood.snap.net.nz> <8f2776cb0605031650o1cf451bex682613fd1434a110@mail.gmail.com> <17497.24251.518395.25087@farnswood.snap.net.nz> <8f2776cb0605041032g54a2a015hb4b8535d5cff5795@mail.gmail.com> <17498.32925.650883.963202@farnswood.snap.net.nz> From: Jim Blandy Date: Fri, 05 May 2006 08:08:00 -0000 In-Reply-To: <17498.32925.650883.963202@farnswood.snap.net.nz> (Nick Roberts's message of "Fri, 5 May 2006 10:30:53 +1200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00052.txt.bz2 Nick Roberts writes: > > > OK, if its a patch for -var-valuate-expression then perhaps the BOGUS > > > comment could be removed as it seems to address this issue. > > > > I read the "BOGUS" comment as referring to the fact that we have to > > specially trap structs and unions, instead of simply passing > > everything through common_val_print. I don't think this patch affects > > that "bogusness"; it just makes the workaround work better. > > I was guessing. I see that the check is for var->type, whereas > perhaps val_print prints out children if var->val->type is a > struct/class. But I don't know the relationship between the two and > you're the expert in these matters. Well, I don't feel very expert in MI; I appreciate having other eyes look stuff over.