From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32299 invoked by alias); 5 May 2004 05:59:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32291 invoked from network); 5 May 2004 05:59:03 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 5 May 2004 05:59:03 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i455x3kG009165 for ; Wed, 5 May 2004 01:59:03 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i455x1v31885; Wed, 5 May 2004 01:59:02 -0400 To: Daniel Jacobowitz Cc: Bryce McKinlay , gdb-patches@sources.redhat.com Subject: Re: Patch: DWARF2 location lists vs. shared libraries References: <40983940.3050003@redhat.com> <20040505040344.GA28793@nevyn.them.org> From: Jim Blandy Date: Wed, 05 May 2004 05:59:00 -0000 In-Reply-To: <20040505040344.GA28793@nevyn.them.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-05/txt/msg00132.txt.bz2 Daniel Jacobowitz writes: > On Tue, May 04, 2004 at 08:45:52PM -0400, Bryce McKinlay wrote: > > 2004-05-04 Bryce McKinlay > > > > * dwarf2read.c (dwarf2_symbol_mark_computed): Use ANOFFSET to > > adjust baton's base_address for shared libraries. > > I spoke briefly to Bryce about this (on IRC). > > I think the right thing to do would be to add the offset when > searching, rather than when saving. This will help us with relocating > objfiles, which I think would be good to support - that way we can > cache debug info for unchanged shared libraries across runs. > > Does this make sense to others? I'll try to write the patch tomorrow > or Thursday. Yes, that's the approach I'd prefer, too. I wish we could apply it to symbols as well, but I don't see how to pull that off.