From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-36692-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 15535 invoked by alias); 4 Nov 2004 18:32:24 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15527 invoked from network); 4 Nov 2004 18:32:23 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 4 Nov 2004 18:32:23 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iA4IWN6K007686
	for <gdb-patches@sources.redhat.com>; Thu, 4 Nov 2004 13:32:23 -0500
Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iA4IWMr31203;
	Thu, 4 Nov 2004 13:32:23 -0500
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: avoid creating inter-objfile type pointers
References: <vt27jp2ccks.fsf@zenia.home>
	<20041104151617.GA28125@nevyn.them.org>
From: Jim Blandy <jimb@redhat.com>
Date: Thu, 04 Nov 2004 18:32:00 -0000
In-Reply-To: <20041104151617.GA28125@nevyn.them.org>
Message-ID: <vt23bzpcvpe.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-11/txt/msg00066.txt.bz2

Daniel Jacobowitz <drow@false.org> writes:

> On Thu, Nov 04, 2004 at 02:12:19AM -0500, Jim Blandy wrote:
> > 
> > This fixes a bug that causes incorrect output and crashes, and which
> > is not caught by the current test suite.  A test could be easily added
> > to shlib-call.exp to catch this; I'll try to give that a shot in a
> > bit.
> > 
> > 2004-11-04  Jim Blandy  <jimb@redhat.com>
> > 
> > 	* gdbtypes.c (make_qualified_type): Doc fix.  Add assertion to
> > 	prevent cross-objfile references.
> > 	(make_cv_type): Doc fix.  Don't create cross-objfile references,
> > 	even for stub types.
> > 	(replace_type): Add assertion to prevent cross-objfile references.
> > 	(check_typedef): Never resolve a stub type by copying over a type
> > 	from another file.
> 
> Oopsie.  This looks sane to me.

Committed, thanks.