From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3793 invoked by alias); 24 Nov 2003 17:55:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3781 invoked from network); 24 Nov 2003 17:55:08 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 24 Nov 2003 17:55:08 -0000 Received: by zenia.home (Postfix, from userid 5433) id 3DD8C20766; Mon, 24 Nov 2003 12:54:52 -0500 (EST) To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/dwarf] Kill some more unnecessary global variables References: <20031123225631.GA26113@nevyn.them.org> From: Jim Blandy Date: Mon, 24 Nov 2003 17:55:00 -0000 In-Reply-To: <20031123225631.GA26113@nevyn.them.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-11/txt/msg00527.txt.bz2 Daniel Jacobowitz writes: > Now that we pass the section to dwarf2_read_section, we don't need to > pass the offset and size parameters also. After removing them, it turns out > that the global offset variables are only: > - passed to dwarf2_read_section > - tested for non-zero-ness to indicate presence of the section > And testing the section pointer works just as well, so we can remove the > offsets. > > This is part of the global state in dwarf2read crusade. The remaining > section info is probably going to move into the objfile as per-objfile data, > but I wanted to prune the deadwood first. > > OK? Yes! Please commit.