From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22832 invoked by alias); 1 Aug 2004 07:01:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22799 invoked from network); 1 Aug 2004 07:01:31 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 1 Aug 2004 07:01:31 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i7171Ue1020634 for ; Sun, 1 Aug 2004 03:01:30 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i7171Sa00716; Sun, 1 Aug 2004 03:01:29 -0400 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/dwarf2] Small problem scanning line table for included files References: <20040725151137.GT20596@gnat.com> <20040730190104.GU1167@gnat.com> <20040730211832.GW1167@gnat.com> From: Jim Blandy Date: Sun, 01 Aug 2004 07:01:00 -0000 In-Reply-To: <20040730211832.GW1167@gnat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-08/txt/msg00004.txt.bz2 Joel Brobecker writes: > > I think you are right. Looking for DW_LNS_set_file was a mistake, since > > it is not fullproof as you demonstrated above. I looked at the dwarf3 > > (draft7) reference again, and setting that flag everytime we need to > > record a line seems to be the perfect place to do (it's a bit > > complicated to explain my resoning, I was concerned mostly because > > I was a bit fuzzy on certain details which were cleared by rereding > > the dwarf3 reference document). > > > > I shall give this a try, and report back. > > This worked beautifully, as expected. Here is a new patch, much simpler. > > 2004-07-30 Joel Brobecker > > * dwarf2read.c (dwarf_decode_lines): Do not consider the current > file as included until we record the first line in the linetable. > > Tested on x86-linux with a GCC-3.4 based compiler, fixes the following > two regressions: > > sep.exp: list using location inside included file > sep.exp: breakpoint inside included file > > I also verified that this test still passes with GCC 3.2. > OK to commit? Yes, please do. Thanks!