Re: [PATCH] Fix 'Undefined command' error message

Eli Zaretskii
2005-11-16T20:00:49Z

> Date: Wed, 16 Nov 2005 13:02:04 +0000
> From: Andrew STUBBS <andrew.stubbs@st.com>
> Cc: gdb-patches@sources.redhat.com
>
> Eli Zaretskii wrote:
> > Why is there a need for testing *p to be non-zero? AFAIK, isalnum is
> > well defined for a zero argument.
> >
> > What is the reason for additional tests under TUI?
> >
> > Is this for some kind of compatibility with XDB?
>
> I do not know the answer to these questions, although I'm sure I could
> look into it. There are already two instances of this code in this file
> and each is implemented identically to the others.

At least the test for *p non-zero should be removed, I think.

> The reason the code is like this here is because it must replicate the
> tests in lookup_cmd_1 if it is to give the right message. I do not know
> why lookup_cmd_1 is the way it is.

Anyone?