From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15682 invoked by alias); 19 Apr 2006 09:07:17 -0000 Received: (qmail 15503 invoked by uid 22791); 19 Apr 2006 09:07:16 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Apr 2006 09:07:14 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-206-41.inter.net.il [80.230.206.41]) by nitzan.inter.net.il (MOS 3.7.3-GA) with ESMTP id DDW78930 (AUTH halo1); Wed, 19 Apr 2006 12:07:10 +0300 (IDT) Date: Wed, 19 Apr 2006 09:07:00 -0000 Message-Id: From: Eli Zaretskii To: Randolph Chung CC: gdb-patches@sources.redhat.com In-reply-to: <4445F4D5.1030302@tausq.org> (message from Randolph Chung on Wed, 19 Apr 2006 16:29:09 +0800) Subject: Re: [rfa] Shared object matching for solib-som.c Reply-to: Eli Zaretskii References: <44458D3D.4030506@tausq.org> <4445F4D5.1030302@tausq.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00258.txt.bz2 > Date: Wed, 19 Apr 2006 16:29:09 +0800 > From: Randolph Chung > CC: gdb-patches@sources.redhat.com > > > Please don't use literal slash characters in GDB sources: they are > > non-portable. AFAICS, you simply need to use lbasename here, on both > > file names. > > I guess you mean "basename" instead of "lbasename". No, I mean lbasename, the one from libiberty. That solves a problem of basename being not portable enough (I think we never use basename in GDB, only lbasename, but I might be wrong). > While I agree with your portability comment, I hope nobody is crazy > enough to use SOM outside of hpux :) Probably not, but people frequently lift code by copy/paste. Anyway, these are our coding standards, AFAIK. > Anyway, I'll redo this using basename. Thanks, but please use lbasename.