Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Automatically use hardware watchpoints
Date: Thu, 09 Nov 2006 21:16:00 -0000	[thread overview]
Message-ID: <uzmb0e2yk.fsf@gnu.org> (raw)
In-Reply-To: <eit8ot$o27$1@sea.gmane.org> (message from Vladimir Prus on Wed, 	08 Nov 2006 21:47:57 +0300)

> From:  Vladimir Prus <vladimir@codesourcery.com>
> Date:  Wed, 08 Nov 2006 21:47:57 +0300
> > 
> > This patch makes insert_bp_location automatically decide what breakpoint
> > type should be used if the target provides a memory map.
> 
> And here's a version of this patch that actually includes doc changes.

Thanks.

> Index: doc/gdb.texinfo
> ===================================================================
> RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
> retrieving revision 1.366
> diff -u -r1.366 gdb.texinfo
> --- doc/gdb.texinfo	27 Oct 2006 22:23:20 -0000	1.366
> +++ doc/gdb.texinfo	1 Nov 2006 11:13:05 -0000

This part is approved, but please take care of the following gotchas:

> +breakpoint address is read-only or read-write. This applies to
                                                ^^
Two spaces between sentences, please.

> +breakpoints set with the ``break'' command as well as to internal
> +breakpoints set by commands like ``next'' and ``finish''. For
> +breakpoints set with ``hbreak'', @value{GDBN} will always use hardware 
> +breakpoints.

Please use @code{break}, @code{next} etc. for command names.

> +This automatic behaviour can be controlled with the following commands::

Passive voice alarm goes off!  How about rewording this as follows:

  You can control this automatic behaviour with the following
  commands:


  reply	other threads:[~2006-11-09 21:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-01 11:48 Vladimir Prus
2006-11-08 18:55 ` Vladimir Prus
2006-11-09 21:16   ` Eli Zaretskii [this message]
2006-11-21 22:23 ` Daniel Jacobowitz
2006-11-22 10:44   ` Vladimir Prus
2006-11-22 10:58     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uzmb0e2yk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox