From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26313 invoked by alias); 29 Dec 2006 12:13:32 -0000 Received: (qmail 26304 invoked by uid 22791); 29 Dec 2006 12:13:32 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 29 Dec 2006 12:13:23 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-201-212.inter.net.il [80.230.201.212]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id GQZ47464 (AUTH halo1); Fri, 29 Dec 2006 14:13:17 +0200 (IST) Date: Fri, 29 Dec 2006 12:13:00 -0000 Message-Id: From: Eli Zaretskii To: Daniel Jacobowitz CC: gdb-patches@sourceware.org In-reply-to: <20061228195533.GA18492@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 28 Dec 2006 14:55:33 -0500) Subject: Re: RFC: Use -Wall -Wextra Reply-to: Eli Zaretskii References: <20061228195533.GA18492@nevyn.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00344.txt.bz2 > Date: Thu, 28 Dec 2006 14:55:33 -0500 > From: Daniel Jacobowitz > > I'd like to hear opinions on this patch. It changes the default set of GDB > build warnings from: > > build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \ > -Wformat -Wparentheses -Wpointer-arith -Wformat-nonliteral \ > -Wunused-label -Wunused-function -Wno-pointer-sign" > > to: > > build_warnings="-Wall -Wextra -Wpointer-arith -Wformat-nonliteral \ > -Wno-pointer-sign -Wno-unused-parameter \ > -Wno-unused -Wno-sign-compare -Wno-switch -Wno-missing-field-initializers" I would agree only if we never try to use -Werror, because with such aggressive warnings GDB will never build if we add -Werror. My other fear is that, with GCC becoming more and more picky about perfectly valid C code, these options will cause the compilation to become very noisy, but I guess we will hear complaints if that happens. > I'd really like to turn on -Wunused too, but it has been off for so long > that we have a substantial number of unused local variables - it will take > some work to clean up. I'd advise against -Wunused: the problems it finds are harmless, whereas fixing them is not trivial at all, and quite ugly in some cases. > Index: doc/gdbint.texinfo > =================================================================== > RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v > retrieving revision 1.247 > diff -u -p -r1.247 gdbint.texinfo > --- doc/gdbint.texinfo 10 Nov 2006 19:20:37 -0000 1.247 > +++ doc/gdbint.texinfo 28 Dec 2006 19:39:07 -0000 This is fine with me, thanks.