From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31905 invoked by alias); 12 Jan 2007 14:36:03 -0000 Received: (qmail 31894 invoked by uid 22791); 12 Jan 2007 14:36:02 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 12 Jan 2007 14:35:56 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-254-59.inter.net.il [80.230.254.59]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id FSQ16896 (AUTH halo1); Fri, 12 Jan 2007 16:35:47 +0200 (IST) Date: Fri, 12 Jan 2007 14:36:00 -0000 Message-Id: From: Eli Zaretskii To: Joel Brobecker CC: gdb-patches@sourceware.org In-reply-to: <20070112071323.GJ537@adacore.com> (message from Joel Brobecker on Fri, 12 Jan 2007 11:13:23 +0400) Subject: Re: [RFA] Improve help set/unset/show substitute-path Reply-to: Eli Zaretskii References: <20070112071323.GJ537@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00316.txt.bz2 > Date: Fri, 12 Jan 2007 11:13:23 +0400 > From: Joel Brobecker > > As promised to Daniel, hopefully the following patch will make the help > text of the vaious substitute-path commands a bit better. Anyone either > wanting to refresh his memory about the usage should now be able to > use the help text for that. It's also easier to use the command without > having read the documentation. Thanks! > +set substitute-path FROM TO\n\ I think it is better to say "Usage: set substitute-path FROM TO". > +Add a source path substitution rule replacing FROM into TO in source paths.\n\ GNU standards dislike such usage of the word ``path''. We should use ``file name'' instead. (``Path'' is reserved for lists of directories, such the values of $PATH and $MANPATH environment variables.) > +unset substitute-path [FROM]\n\ > +If a path is specified (FROM), delete the associated rule from the current\n\ > +list of substitution rules. A warning is emmitted by the debugger if\n\ > +no rule could be found.\n\ > +If no path is specified, then all substitution rules are deleted."), I suggest to say this instead: Delete the rule for substituting FROM in source file names. If FROM is not specified, all substituting rules are deleted. If the debugger cannot find a rule for FROM, it will display a warning. > +show substitute-path [FROM]\n\ > +If a path is specified (FROM), print the source path substitution rule which\n\ Same here.