From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-58001-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18191 invoked by alias); 15 Aug 2008 17:08:25 -0000
Received: (qmail 18179 invoked by uid 22791); 15 Aug 2008 17:08:25 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout4.012.net.il (HELO mtaout4.012.net.il) (84.95.2.10)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 15 Aug 2008 17:07:46 +0000
Received: from HOME-C4E4A596F7 ([84.229.211.50]) by i_mtaout4.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K5N00BJCJJ4NMZ0@i_mtaout4.012.net.il> for gdb-patches@sourceware.org; Fri, 15 Aug 2008 20:06:40 +0300 (IDT)
Date: Fri, 15 Aug 2008 17:08:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH-ppc 5/5] Add VSX doc bits
In-reply-to: <1218814096.8946.39.camel@gargoyle>
X-012-Sender: halo1@inter.net.il
To: luisgpm@linux.vnet.ibm.com
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uzlnedx87.fsf@gnu.org>
References: <1217016956.29012.79.camel@gargoyle> <1218814096.8946.39.camel@gargoyle>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-08/txt/msg00424.txt.bz2

> From: Luis Machado <luisgpm@linux.vnet.ibm.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 15 Aug 2008 12:28:16 -0300
> 
> What do you think about the doc bits for this one?
> 
> Regards,
> > 2008-07-25  Luis Machado  <luisgpm@br.ibm.com>
> > 
> > 	* doc/gdb.texinfo: Updated documentation with new support info.	

This needs to state the node name where the changes are made.

> > 
> > Index: gdb/doc/gdb.texinfo
> > ===================================================================
> > --- gdb.orig/doc/gdb.texinfo	2008-07-23 09:28:06.000000000 -0700
> > +++ gdb/doc/gdb.texinfo	2008-07-23 09:31:44.000000000 -0700
> > @@ -16210,6 +16210,9 @@
> >  by joining the even/odd register pairs @code{f0} and @code{f1} for @code{$dl0},
> >  @code{f2} and @code{f3} for @code{$dl1} and so on.
> > 
> > +For POWER7 processors, GDB provides a new set of pseudo-registers, the 64-bit
> > +wide Extended Floating Point Registers (@samp{f32} through @samp{f63}).
> > +
> > 
> >  @node Controlling GDB
> >  @chapter Controlling @value{GDBN}
> > @@ -27406,6 +27409,13 @@
> >  contain registers @samp{vr0} through @samp{vr31}, @samp{vscr},
> >  and @samp{vrsave}.
> > 
> > +The @samp{org.gnu.gdb.power.vsx} feature is optional.  It should
> > +contain registers @samp{vs0h} through @samp{vs31h}.  @value{GDBN}
> > +will combine these registers with the floating point registers
> > +(@samp{f0} through @samp{f31}) and the altivec registers (@samp{vr0}
> > +through @samp{vr31}} to present the 128-bit wide registers @samp{vs0}
> > +through @samp{vs63}, the new set of vector registers for POWER7.
> > +

This is OK, modulo Stan's comments on using "new".