From: Eli Zaretskii <eliz@gnu.org>
To: Denis PILAT <denis.pilat@st.com>
Cc: gdb-patches@sources.redhat.com, bash-maintainers@gnu.org
Subject: Re: [readline-mingw] backspace key and TUI size
Date: Wed, 08 Feb 2006 16:28:00 -0000 [thread overview]
Message-ID: <uy80l4xy7.fsf@gnu.org> (raw)
In-Reply-To: <43E9A5B1.1030001@st.com> (message from Denis PILAT on Wed, 08 Feb 2006 09:02:57 +0100)
> Date: Wed, 08 Feb 2006 09:02:57 +0100
> From: Denis PILAT <denis.pilat@st.com>
> Cc: bash-maintainers@gnu.org
>
> - In the gdb.exe version, the backspace key do not behave correctly.
Like Daniel, I don't see this problem on my system.
> +/* For mingw version, we get console size from windows API*/
> +#if defined (__MINGW32__)
> + HANDLE hConOut = GetStdHandle(STD_OUTPUT_HANDLE);
> + CONSOLE_SCREEN_BUFFER_INFO scr;
> + GetConsoleScreenBufferInfo(hConOut, &scr);
> + _rl_screenwidth = scr.dwSize.X;
> + _rl_screenheight = scr.srWindow.Bottom - scr.srWindow.Top + 1;
> +#endif
Shouldn't you make sure the handle returned by GetStdHandle is not
INVALID_HANDLE_VALUE, before you use it in a system call?
> -#ifndef __MSDOS__
> - if (_rl_term_backspace)
> +#if !defined (__MSDOS__) && !defined (__MINGW32__)
> + if (_rl_term_backspace)
The idea is okay with me, but there;s a stray blank after the last
line above. Please remove it.
And thanks for working on this.
prev parent reply other threads:[~2006-02-08 16:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 8:03 Denis PILAT
2006-02-08 13:43 ` Daniel Jacobowitz
2006-02-08 16:03 ` Denis PILAT
2006-02-08 16:05 ` Bob Rossi
2006-02-08 16:14 ` Daniel Jacobowitz
2006-02-08 16:30 ` Chet Ramey
2006-02-08 16:48 ` Andrew STUBBS
2006-02-08 16:51 ` Daniel Jacobowitz
2006-02-08 17:04 ` Chet Ramey
2006-02-08 17:13 ` Daniel Jacobowitz
2006-02-08 17:54 ` Eli Zaretskii
2006-02-08 17:09 ` Eli Zaretskii
2006-02-08 17:30 ` Andrew STUBBS
2006-02-08 17:40 ` Daniel Jacobowitz
2006-02-09 9:36 ` Denis PILAT
2006-02-09 13:49 ` Daniel Jacobowitz
2006-02-10 15:41 ` Denis PILAT
2006-02-10 18:52 ` Eli Zaretskii
2006-02-20 15:36 ` Daniel Jacobowitz
2006-02-23 18:25 ` Daniel Jacobowitz
2006-02-24 8:36 ` Eli Zaretskii
2006-02-24 18:44 ` Daniel Jacobowitz
2006-02-24 18:48 ` Eli Zaretskii
2006-02-24 19:29 ` Daniel Jacobowitz
2006-02-25 11:35 ` Eli Zaretskii
2006-02-08 17:56 ` Eli Zaretskii
2006-02-08 18:03 ` Daniel Jacobowitz
2006-02-08 16:28 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uy80l4xy7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=bash-maintainers@gnu.org \
--cc=denis.pilat@st.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox