From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18728 invoked by alias); 3 Aug 2007 12:31:57 -0000 Received: (qmail 18715 invoked by uid 22791); 3 Aug 2007 12:31:55 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Aug 2007 12:31:52 +0000 Received: from HOME-C4E4A596F7 (IGLD-83-130-197-78.inter.net.il [83.130.197.78]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id DGV93285 (AUTH halo1); Fri, 3 Aug 2007 15:31:47 +0300 (IDT) Date: Fri, 03 Aug 2007 12:31:00 -0000 Message-Id: From: Eli Zaretskii To: "Michael Snyder" CC: drow@false.org, gdb-patches@sourceware.org In-reply-to: <006901c7d587$db360400$677ba8c0@sonic.net> (msnyder@sonic.net) Subject: Re: [PATCH] symfile.c, find_separate_debug_file Reply-to: Eli Zaretskii References: <10431.12.7.175.2.1186103684.squirrel@webmail.sonic.net> <20070803013005.GA22901@caradoc.them.org> <006901c7d587$db360400$677ba8c0@sonic.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00047.txt.bz2 > From: "Michael Snyder" > Cc: > Date: Thu, 2 Aug 2007 21:36:27 -0700 > > > > * symfile.c (find_separate_debug_file): While consing up a path, > > > don't stick in an extra DIR_SEPARATOR. > > > > That's right, use DIR_SEPARATOR :-) IS_DIR_SEPARATOR in this case, I > > think? > > The existing code doesn't use it. Correction: the existing code appends "/" unconditionally, which is fine, since both Posix and non-Posix platforms support forward slashes in file names. But Daniel didn't mean that: he meant to use IS_DIR_SEPARATOR instead of literal comparison to '/' alone. The existing code didn't test anything, so it didn't have to cope with this issue.