From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-26779-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 26391 invoked by alias); 3 Sep 2003 10:27:45 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 26384 invoked from network); 3 Sep 2003 10:27:44 -0000
Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173)
  by sources.redhat.com with SMTP; 3 Sep 2003 10:27:44 -0000
Received: from [207.232.27.5] (helo=WST0054)
	by monty-python.gnu.org with asmtp (Exim 4.22)
	id 19uUqi-0007E3-8E; Wed, 03 Sep 2003 06:26:52 -0400
Date: Wed, 03 Sep 2003 10:27:00 -0000
Message-Id: <uwucq1578.fsf@elta.co.il>
From: Eli Zaretskii <eliz@elta.co.il>
To: Corinna Vinschen <vinschen@redhat.com>
CC: gdb-patches@sources.redhat.com
In-reply-to: <20030903093815.GQ1859@cygbert.vinschen.de> (message from Corinna
	Vinschen on Wed, 3 Sep 2003 11:38:15 +0200)
Subject: Re: [RFA] breakpoint.c, scanning epilogue if frame chain is invalid
Reply-to: Eli Zaretskii <eliz@elta.co.il>
References:  <20030903093815.GQ1859@cygbert.vinschen.de>
X-SW-Source: 2003-09/txt/msg00013.txt.bz2

> Date: Wed, 3 Sep 2003 11:38:15 +0200
> From: Corinna Vinschen <vinschen@redhat.com>
> 
> -      if (within_current_scope && fr == get_current_frame ()
> +      if ((!within_current_scope || fr == get_current_frame ())
>            && gdbarch_in_function_epilogue_p (current_gdbarch, read_pc ()))
>  	return WP_VALUE_NOT_CHANGED;
>        if (within_current_scope)
> [...]
> The above patch is basically this:  If we couldn't find the watchpoint
> frame, at least try to find out if PC is just in an epilogue.  If so,
> it's probably the cause of failing to find the watchpoint frame so just
> leave the watchpoint alone until we're on firmer ground again.

I'm not sure I understand why did you change

    within_current_scope && fr == get_current_frame ()

into

    (!within_current_scope || fr == get_current_frame ())

It doesn't seem to follow from the verbal description of the decision
you'd like the code to make.  Perhaps I'm missing something, so could
you please elaborate how the verbal description translates into the
code?