Re: [commit] Deprecate remaining STREQ uses

Andrew Cagney
2003-11-27T14:30:21Z

> Even if the process isn't entirely automated, it's still sometimes
> better to do the conversion all at once. By deprecating something,
> you're forcing someone else (or even a later version of yourself) to
> deal with the problem later on.

If a contributor wants to add new code, or fix bugs in existing code,
they should not be increasing the use of existing deprecated mechanisms
(after all we should be able to reasonably expect contributors to not
make matters worse). The prime motivator here should our joint goal to
make GDB the best debgger possible, and more immediatly our desire to
fix bugs such as those identified by my rewritten structs.exp. As for
other code, let it bitrot and die.

To give two tangable examples:

http://sources.redhat.com/ml/gdb-patches/2003-08/msg00017.html
> See: http://sources.redhat.com/gdb/current/ari/
> The method get_frame_saved_regs() is obsolete. Changes should be decreasing, not increasing that function's usage count :-/ The new code will need to be written in a way that avoids this method. The best way of doing this is to convert it to convert that section of the code to the new unwind mechanism.

while I recommended using the new frame code, you'll note that I
definitly didn't require it. There were other ways of doing this that
would have reduced the deprecated count that did not involve a frame
conversion.

Similarly with the PPC and PPC64, you'll note that I've been fixing a
depressing number of bugs in existing code, while at each step
eliminating deprecated code.

Andrew