From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29681 invoked by alias); 4 Dec 2003 08:30:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29653 invoked from network); 4 Dec 2003 08:30:35 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 4 Dec 2003 08:30:35 -0000 Received: from [207.232.27.5] (helo=WST0054) by monty-python.gnu.org with asmtp (Exim 4.24) id 1ARppb-0005pr-Sg; Thu, 04 Dec 2003 04:31:32 -0500 Date: Thu, 04 Dec 2003 08:30:00 -0000 Message-Id: From: Eli Zaretskii To: "J. Johnston" CC: gdb-patches@sources.redhat.com In-reply-to: <3FCE3DA9.2000603@redhat.com> (jjohnstn@redhat.com) Subject: Re: [RFC]: pending break support Reply-to: Eli Zaretskii References: <3FCD3DC5.8000308@redhat.com> <3405-Wed03Dec2003180427+0200-eliz@elta.co.il> <3FCE3DA9.2000603@redhat.com> X-SW-Source: 2003-12/txt/msg00108.txt.bz2 > Date: Wed, 03 Dec 2003 14:46:49 -0500 > From: "J. Johnston" > > How about the following updated patch? I tied together why I was talking about > the various operations on pending breakpoints which makes the grouping of the > information make more sense. Okay. I'm down to nit-picking now: > +If a specified breakpoint location cannot be found, you will be prompted > +as to whether you want to make the breakpoint pending on a future shared I'd replace "you will be prompted" with "@value{GDBN} will prompt you". Native English speakers keep telling me that using passive forms is BAD. > +Normal breakpoint operations apply to pending breakpoints as well. You may > +specify, a condition for a pending breakpoint, commands to run when the ^ The comma I marked should not be there, I think.