From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30442 invoked by alias); 24 Jun 2006 13:51:29 -0000 Received: (qmail 30431 invoked by uid 22791); 24 Jun 2006 13:51:28 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 24 Jun 2006 13:51:27 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-9-245.inter.net.il [80.230.9.245]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id EYV93489 (AUTH halo1); Sat, 24 Jun 2006 16:51:19 +0300 (IDT) Date: Sat, 24 Jun 2006 13:51:00 -0000 Message-Id: From: Eli Zaretskii To: Michael Fischer , gdb-patches@sourceware.org In-reply-to: <20060620202742.GD1453@nevyn.them.org> (message from Daniel Jacobowitz on Tue, 20 Jun 2006 16:27:42 -0400) Subject: Re: AW: AW: [PATCH] source.s: Fix problem handling windows like path with MinGW Reply-to: Eli Zaretskii References: <20060618201551.GA6038@trixie.casa.cgf.cx> <20060620202742.GD1453@nevyn.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00373.txt.bz2 > Date: Tue, 20 Jun 2006 16:27:42 -0400 > From: Daniel Jacobowitz > Cc: Michael Fischer , gdb-patches@sourceware.org > > Personally, I'd grab the #define from libiberty/make-relative-prefix.c, > and maybe even move it into include/filenames.h. That one's better > tested. But it uses ';' if _WIN32, so don't ask me how that works for > Cygwin builds. Maybe it doesn't. > > I'm fine with Chris's suggested definition, naturally. Thanks to you and Chris for all the feedback. I eventually opted for the change in defs.h, to avoid the risk of breaking something else that uses include/filenames.h. Here's what I actually committed: 2006-06-24 Eli Zaretskii * defs.h (DIRNAME_SEPARATOR) [!__CYGWIN__ && _WIN32]: Define to `;'. Index: gdb/defs.h =================================================================== RCS file: /cvs/src/src/gdb/defs.h,v retrieving revision 1.194 diff -u -r1.194 defs.h --- gdb/defs.h 25 Feb 2006 04:36:39 -0000 1.194 +++ gdb/defs.h 24 Jun 2006 13:47:43 -0000 @@ -1163,6 +1163,10 @@ # define DIRNAME_SEPARATOR ';' #endif +#if !defined (__CYGWIN__) && defined (_WIN32) +# define DIRNAME_SEPARATOR ';' +#endif + #ifndef DIRNAME_SEPARATOR #define DIRNAME_SEPARATOR ':' #endif