From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47449-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21728 invoked by alias); 30 Jan 2007 20:24:02 -0000
Received: (qmail 21718 invoked by uid 22791); 30 Jan 2007 20:24:01 -0000
X-Spam-Check-By: sourceware.org
Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 30 Jan 2007 20:23:56 +0000
Received: from HOME-C4E4A596F7 (IGLD-84-229-122-219.inter.net.il [84.229.122.219]) 	by heller.inter.net.il (MOS 3.7.3a-GA) 	with ESMTP id BTH67529 (AUTH halo1); 	Tue, 30 Jan 2007 22:23:28 +0200 (IST)
Date: Tue, 30 Jan 2007 20:24:00 -0000
Message-Id: <uwt348dru.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
CC: gdb-patches@sources.redhat.com
In-reply-to: <200701301337.14436.vladimir@codesourcery.com> (message from 	Vladimir Prus on Tue, 30 Jan 2007 13:37:14 +0300)
Subject: Re: [ob] fix mingw compilation
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <200701301337.14436.vladimir@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-01/txt/msg00598.txt.bz2

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Tue, 30 Jan 2007 13:37:14 +0300
> 
> @@ -765,18 +768,20 @@ pipe_windows_close (struct serial *scb)
>  static int
>  pipe_windows_read (struct serial *scb, size_t count)
>  {
> -  HANDLE pipeline_out = (HANDLE) _get_osfhandle (scb->fd);
> +  HANDLE pipeline_out;

This one-line change is unnecessary; please put back the original
code, it's perfectly valid C, and shouldn't trigger any warnings or
errors from GCC.

The other changes are okay.

Thanks.