From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15986 invoked by alias); 8 Jan 2008 20:42:36 -0000 Received: (qmail 15978 invoked by uid 22791); 8 Jan 2008 20:42:35 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 08 Jan 2008 20:42:16 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-228-239-211.inter.net.il [84.228.239.211]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id JVU44829 (AUTH halo1); Tue, 8 Jan 2008 22:41:16 +0200 (IST) Date: Tue, 08 Jan 2008 20:42:00 -0000 Message-Id: From: Eli Zaretskii To: luisgpm@linux.vnet.ibm.com CC: gdb-patches@sourceware.org In-reply-to: <1199798856.22083.9.camel@gargoyle> (message from Luis Machado on Tue, 08 Jan 2008 11:27:36 -0200) Subject: Re: [PATCH] Improve printf DFP support Reply-to: Eli Zaretskii References: <1199798856.22083.9.camel@gargoyle> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00162.txt.bz2 > From: Luis Machado > Date: Tue, 08 Jan 2008 11:27:36 -0200 > > This is an improvement over the last patch i have submited to add DFP > support for GDB's printf command. > > The DFP modifiers are now being treated as length modifiers, and not > type modifiers. This puts us in agreement with what the C99 standard's > DFP annex says. > > The parsing of the string is a bit more robust than the last version. > > A documentation and testcase updated is attached as well. Thanks. The documentation part of the patch is approved, but please include in the ChangeLog entry the name of the node where you make the change, as if it were a function.