From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-59936-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25104 invoked by alias); 14 Nov 2008 11:19:26 -0000
Received: (qmail 25060 invoked by uid 22791); 14 Nov 2008 11:19:26 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout6.012.net.il (HELO mtaout6.012.net.il) (84.95.2.16)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Nov 2008 11:18:29 +0000
Received: from conversion-daemon.i-mtaout6.012.net.il by i-mtaout6.012.net.il (HyperSendmail v2007.08) id <0KAB00500M1OFG00@i-mtaout6.012.net.il> for gdb-patches@sourceware.org; Fri, 14 Nov 2008 13:20:18 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.205.49]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KAB00JZ1M5TMSF0@i-mtaout6.012.net.il>; Fri, 14 Nov 2008 13:20:18 +0200 (IST)
Date: Fri, 14 Nov 2008 15:32:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Darwin/x86 port (v3 of part 3: i386-darwin files)
In-reply-to: <20081112125150.GA21514@ulanbator.act-europe.fr>
X-012-Sender: halo1@inter.net.il
To: Tristan Gingold <gingold@adacore.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uwsf6o8se.fsf@gnu.org>
References: <20081112125150.GA21514@ulanbator.act-europe.fr>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00327.txt.bz2

> Date: Wed, 12 Nov 2008 13:51:50 +0100
> From: Tristan Gingold <gingold@adacore.com>
> 
> i386-darwin-tdep.h:

Thanks.

> /* Offsets into the struct i386_thread_state where we'll find the saved regs. */
> /* From <mach/i386/thread_status.h and i386-tdep.h */
                                    ^
A closing bracket `>' is missing here.

> /* Offsets into the struct x86_thread_state64 where we'll find the saved regs. */
> /* From <mach/i386/thread_status.h and amd64-tdep.h */
                                    ^
And here.

> 	  if (ret != KERN_SUCCESS)
> 	    {
> 	      printf ("Error calling thread_get_state for GP registers for thread 0x%ulx", current_thread);
> 	      MACH_CHECK_ERROR (ret);

printf? is that right? didn't you mean printf_filtered or
printf_unfiltered?

In any case, please enclose all user messages in _(), for when we will
support l10n.

(There are several similar instances elsewhere in this patch.)

>   if (! fetched)
>     {
>       warning ("unknown register %d", regno);

Same here: please use _().