From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4246 invoked by alias); 5 Feb 2009 20:30:52 -0000 Received: (qmail 4236 invoked by uid 22791); 5 Feb 2009 20:30:51 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout2.012.net.il (HELO mtaout2.012.net.il) (84.95.2.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Feb 2009 20:30:45 +0000 Received: from conversion-daemon.i_mtaout2.012.net.il by i_mtaout2.012.net.il (HyperSendmail v2004.12) id <0KEM005000UCC700@i_mtaout2.012.net.il> for gdb-patches@sourceware.org; Thu, 05 Feb 2009 22:31:05 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.238.131]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KEM00EEX0ZN3CO2@i_mtaout2.012.net.il>; Thu, 05 Feb 2009 22:31:00 +0200 (IST) Date: Thu, 05 Feb 2009 20:30:00 -0000 From: Eli Zaretskii Subject: Re: [1/2] Inspect extra signal information In-reply-to: <200902050114.05103.pedro@codesourcery.com> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <200901121846.51709.pedro@codesourcery.com> <200902021652.28152.pedro@codesourcery.com> <200902050114.05103.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00135.txt.bz2 > From: Pedro Alves > Date: Thu, 5 Feb 2009 01:14:04 +0000 > > Here's a proper patch. > > Does it look OK? Yes, but I have a couple of nits: > +A value is in addition descriminated by its lvalue-ness, given its ^^^^^^^^^^^^^ "discriminated" > +Represents part of a gdb internal variable. E.g., a structure field. ^^^ @value{GDBN} > +objects for specific purposes, all abstracted way from the the core ^^^ ^^^^^^^ "way" or "away"? Also, lose the extra "the". Thanks.