From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61746-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23727 invoked by alias); 17 Feb 2009 20:37:42 -0000
Received: (qmail 23714 invoked by uid 22791); 17 Feb 2009 20:37:41 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Feb 2009 20:37:33 +0000
Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il (HyperSendmail v2004.12) id <0KF800I0098GXJ00@i_mtaout5.012.net.il> for gdb-patches@sourceware.org; Tue, 17 Feb 2009 22:37:47 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.228.82.14]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KF8006EF9AV3G11@i_mtaout5.012.net.il>; Tue, 17 Feb 2009 22:37:44 +0200 (IST)
Date: Tue, 17 Feb 2009 20:50:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Modernize solaris threads support.
In-reply-to: <m33aec4yw0.fsf@fleche.redhat.com>
To: tromey@redhat.com
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uwsbovlyx.fsf@gnu.org>
References: <200902160549.49108.pedro@codesourcery.com> <200902162050.49191.pedro@codesourcery.com> <ubpt1wwae.fsf@gnu.org> <200902171310.24234.pedro@codesourcery.com> <u63j8x4of.fsf@gnu.org> <m33aec4yw0.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-02/txt/msg00365.txt.bz2

> Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Tue, 17 Feb 2009 13:00:31 -0700
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Perdo> If you still want those declarations for some reason, I'll
> Pedro> put them back.
> 
> Eli> Please do, and thanks.
> 
> Please also provide your rationale.
> We know Pedro's, but we don't know yours.

It's a matter of personal preferences, that's why I didn't explain it
in the first place.  I prefer to have the prototypes because that
avoids problems when functions are rearranged so that some are used
before they are defined.

I also dislike gratuitous changes in code that is there for at least 9
years.

As long as these preferences don't contradict GNU coding conventions
and guidelines, I'd like to stick to them.