From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18815 invoked by alias); 28 Jul 2005 19:07:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17754 invoked by uid 22791); 28 Jul 2005 19:07:20 -0000 Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 28 Jul 2005 19:07:20 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-228-249-198.inter.net.il [84.228.249.198]) by romy.inter.net.il (MOS 3.5.8-GR) with ESMTP id BZC03635 (AUTH halo1); Thu, 28 Jul 2005 22:07:11 +0300 (IDT) Date: Thu, 28 Jul 2005 19:07:00 -0000 Message-Id: From: Eli Zaretskii To: "Kaveh R. Ghazi" CC: gdb-patches@sources.redhat.com In-reply-to: <200507280310.j6S3AvjH011703@caipclassic.rutgers.edu> (ghazi@caipclassic.rutgers.edu) Subject: Re: PATCH: add format attributes to gdb Reply-to: Eli Zaretskii References: <200507280310.j6S3AvjH011703@caipclassic.rutgers.edu> X-SW-Source: 2005-07/txt/msg00222.txt.bz2 > Date: Wed, 27 Jul 2005 23:10:57 -0400 (EDT) > From: "Kaveh R. Ghazi" > Cc: ghazi@caipclassic.rutgers.edu > > This patch adds format attributes in various places in gdb. I found > these mainly by compiling gdb using a snapshot of gcc-4.1.x with > -Wmissing-format-attribute. (GCC 4.1.x has some improvements that > find more places to add missing format attributes.) Thanks. > 2005-07-27 Kaveh R. Ghazi > > * cli-out.c (cli_field_fmt, cli_message, out_field_fmt): Add > ATTR_FORMAT or ATTRIBUTE_FPTR_PRINTF. > * complaints.c (vcomplaint): Likewise. > * defs.h (xvasprintf, xstrvprintf, verror, vfatal, > internal_verror, internal_vwarning, vwarning, > deprecated_query_hook, deprecated_warning_hook, > deprecated_readline_begin_hook): Likewise. Nitpicking: these multi-line entries are not according to the GNU coding standards (which specify that each line must end with a right paren).