From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-45209-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32492 invoked by alias); 31 Jul 2006 20:14:31 -0000
Received: (qmail 32481 invoked by uid 22791); 31 Jul 2006 20:14:30 -0000
X-Spam-Check-By: sourceware.org
Received: from heller.inter.net.il (HELO heller.inter.net.il) (192.114.186.73)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 31 Jul 2006 20:14:27 +0000
Received: from HOME-C4E4A596F7 (IGLD-80-230-39-32.inter.net.il [80.230.39.32]) 	by heller.inter.net.il (MOS 3.7.3a-GA) 	with ESMTP id ACY70325 (AUTH halo1); 	Mon, 31 Jul 2006 23:14:19 +0300 (IDT)
Date: Mon, 31 Jul 2006 20:14:00 -0000
Message-Id: <uvepdmt0h.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: =?ISO-8859-1?Q?Fr=E9d=E9ric?= Riss <frederic.riss@gmail.com>
CC: frederic.riss@st.com, drow@false.org, schwab@suse.de,         gdb-patches@sources.redhat.com
In-reply-to: <1154376407.5120.27.camel@funkylaptop> (message from 	=?ISO-8859-1?Q?Fr=E9d=E9ric?= Riss on Mon, 31 Jul 2006 22:06:47 +0200)
Subject: Re: [RFC] New threadnum command for breakpoints
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <1154093921.28300.236.camel@crx549.cro.st.com> 	 <jeu051eshy.fsf@sykes.suse.de> 	 <1154093921.28300.236.camel@crx549.cro.st.com> 	 <20060728141339.GA15103@nevyn.them.org> 	 <1154098563.28300.282.camel@crx549.cro.st.com> 	 <20060728151434.GA17238@nevyn.them.org> 	 <1154334744.28300.302.camel@crx549.cro.st.com> 	 <20060731125311.GA1272@nevyn.them.org> 	 <1154354425.28300.335.camel@crx549.cro.st.com> <1154376407.5120.27.camel@funkylaptop>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-07/txt/msg00435.txt.bz2

> From: =?ISO-8859-1?Q?Fr=E9d=E9ric?= Riss <frederic.riss@gmail.com>
> Cc: Daniel Jacobowitz <drow@false.org>, Andreas Schwab <schwab@suse.de>,  gdb-patches@sources.redhat.com
> Date: Mon, 31 Jul 2006 22:06:47 +0200
> 
> Here's a code patch for discussion and a tentative doco patch.

Thanks.

> 2006-07-31  Frederic Riss  <frederic.riss@st.com>
> 
> 	* gdb.texinfo (Stopping and starting multi-thread programs): Mention
> 	the $_gdb_thread convenience variable.

One minor comment to this doco patch:

> --- gdb.texinfo	21 Jul 2006 14:46:55 -0000	1.345
> +++ gdb.texinfo	31 Jul 2006 19:22:50 -0000
> @@ -4208,8 +4208,10 @@ breakpoints on all threads, or on a part
>  @cindex breakpoints and threads
>  @cindex thread breakpoints
>  @kindex break @dots{} thread @var{threadno}
> +@vindex $_gdb_thread@r{, convenience variable}

Please move this @vindex line to before the paragraph that actually
describes the feature.  This makes the index reference the right page
in the printed version of the manual.

Other than that, the documentation patch is okay with me.