From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47917-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24510 invoked by alias); 5 Mar 2007 21:04:54 -0000
Received: (qmail 24502 invoked by uid 22791); 5 Mar 2007 21:04:54 -0000
X-Spam-Check-By: sourceware.org
Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 05 Mar 2007 21:04:45 +0000
Received: from HOME-C4E4A596F7 (IGLD-80-230-33-230.inter.net.il [80.230.33.230]) 	by romy.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id HHR95246 (AUTH halo1); 	Mon, 5 Mar 2007 23:04:37 +0200 (IST)
Date: Mon, 05 Mar 2007 21:04:00 -0000
Message-Id: <uvehfmmfj.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Markus Deuling <deuling@de.ibm.com>
CC: pedro_alves@portugalmail.pt, gdb-patches@sourceware.org
In-reply-to: <45EBB15E.4000602@de.ibm.com> (message from Markus Deuling on 	Mon, 05 Mar 2007 06:57:50 +0100)
Subject: Re: [Patch]: Little Cleanup
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <45E7CC17.5040304@de.ibm.com> <45E93AE5.5050704@portugalmail.pt> <ulkie62od.fsf@gnu.org> <45EBB15E.4000602@de.ibm.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-03/txt/msg00048.txt.bz2

> Date: Mon, 05 Mar 2007 06:57:50 +0100
> From: Markus Deuling <deuling@de.ibm.com>
> CC: Pedro Alves <pedro_alves@portugalmail.pt>, gdb-patches@sourceware.org
> 
>        if (!breakpoints_inserted && !ecs->another_trap)
>  	{
> -	  breakpoints_failed = insert_breakpoints ();
> -	  if (breakpoints_failed)
> +          if (insert_breakpoints () != 0)
>  	    {
>  	      stop_stepping (ecs);
>  	      return;

I thought we agreed about adding a comment here, something like:

  /* insert_breakpoints returns non-zero if it fails to insert the
     breakpoints.  */