From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17999 invoked by alias); 13 Jun 2006 03:39:26 -0000 Received: (qmail 17988 invoked by uid 22791); 13 Jun 2006 03:39:25 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Jun 2006 03:39:24 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-156-203.inter.net.il [80.230.156.203]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id EWG30426 (AUTH halo1); Tue, 13 Jun 2006 06:39:17 +0300 (IDT) Date: Tue, 13 Jun 2006 03:39:00 -0000 Message-Id: From: Eli Zaretskii To: Nick Roberts CC: gdb-patches@sources.redhat.com In-reply-to: <17549.1830.40223.127804@kahikatea.snap.net.nz> (message from Nick Roberts on Mon, 12 Jun 2006 18:18:14 +1200) Subject: Re: [PATCH] MI Doco Reply-to: Eli Zaretskii References: <17535.33986.598009.914783@kahikatea.snap.net.nz> <17536.4472.263731.425097@kahikatea.snap.net.nz> <17538.8607.697546.427486@kahikatea.snap.net.nz> <17546.915.125070.943811@kahikatea.snap.net.nz> <17547.15381.217912.425365@kahikatea.snap.net.nz> <17547.60705.62123.543072@kahikatea.snap.net.nz> <17548.36381.999594.50258@kahikatea.snap.net.nz> <17549.1830.40223.127804@kahikatea.snap.net.nz> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00165.txt.bz2 > From: Nick Roberts > Date: Mon, 12 Jun 2006 18:18:14 +1200 > Cc: gdb-patches@sources.redhat.com > > > I already approved the second patch (which AFAIU was just like the one > > before, with my comments resolved, and I said in response to the first > > patch that once the comments are taken care of, you can commit). I > > also approved the reordering you asked about. > > Just one part of the second patch (GDB/MI Compatibility with CLI) was part of > the previous patch. Are you clear about/OK with this part?: > > (GDB/MI Data Manipulation): Remove description of unimplemented > display related commands as variable objects perform this function > and are superior: -display-delete, -display-disable, > -display-enable, -display-insert and -display-list. Move > -environment-cd, -environment-directory, -environment-path > and -environment-pwd to "Program Context". Please don't do things like that: please don't mix a corrected patch with another as yet unseen patch, especially not in such large patches. I checked a few changes, saw that you fixed my comments, and didn't look farther. I cannot afford reading such large patches several times; I usually trust people that when they say they took care of my comments, they really did. Now please post only the new parts, the ones I've never seen. Please don't commit anything before that.