From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15849 invoked by alias); 20 Dec 2006 19:44:29 -0000 Received: (qmail 15839 invoked by uid 22791); 20 Dec 2006 19:44:28 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 20 Dec 2006 19:44:22 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-22-127.inter.net.il [80.230.22.127]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id FNC02058 (AUTH halo1); Wed, 20 Dec 2006 21:44:16 +0200 (IST) Date: Wed, 20 Dec 2006 19:44:00 -0000 Message-Id: From: Eli Zaretskii To: Vladimir Prus CC: gdb-patches@sources.redhat.com In-reply-to: <200612202137.29038.vladimir@codesourcery.com> (message from Vladimir Prus on Wed, 20 Dec 2006 21:37:28 +0300) Subject: Re: [mi] [ada] varobjs for registers 2 Reply-to: Eli Zaretskii References: <200612202137.29038.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00268.txt.bz2 > From: Vladimir Prus > Date: Wed, 20 Dec 2006 21:37:28 +0300 > > This is a second revision of the patch to add MI command that > creates varobjs for registers. The command is renamed to -var-list > and used like: > > -var-list --registers > > There are now docs and tests. The created variable objects no longer > have 'public' pseudo-fields, no matter what the language of the program is. > > Along the way, I've promoted a private function in ada-lang.c to language.c, > so I'd appreciate if Ada maintainers take a quick look. > > OK? Thanks. The patch for the manual is approved, but please take care of these minor problems: > +This command is intended to efficiently create a number of variable > +objects---for example for registers, or for local variables. Using > +the @code{-var-create} command would not be ideal, because it must be > +issued once for every variable object. Please add a cross-reference to the description of -var-create here. > +be used with caution, as gdb can determine the value in the parent ^^^ Please use @value{GDBN}. > +The MI result record includes the @samp{result} field which value is ^^^^^^ "whose value is..." > +a list of tuples. Each tuple describes a single variable object in > +the same was as for the @code{-var-create} command: ^^^^^^^^^^^^^^^^^^^ Something's wrong here. > +@smallexample > +^done,registers=[{name="var1",exp="$eax",numchild="0",value="16",type="int"},.... > +@end smallexample This line is too long for @smallexample, please break it into two lines.