From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7551 invoked by alias); 5 Mar 2007 21:23:33 -0000 Received: (qmail 7540 invoked by uid 22791); 5 Mar 2007 21:23:31 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (213.8.233.22) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 05 Mar 2007 21:23:27 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-33-230.inter.net.il [80.230.33.230]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id GFL84901 (AUTH halo1); Mon, 5 Mar 2007 23:23:20 +0200 (IST) Date: Mon, 05 Mar 2007 21:23:00 -0000 Message-Id: From: Eli Zaretskii To: Mark Kettenis CC: deuling@de.ibm.com, pedro_alves@portugalmail.pt, gdb-patches@sourceware.org In-reply-to: <200703052119.l25LJKVw021917@brahms.sibelius.xs4all.nl> (message from Mark Kettenis on Mon, 5 Mar 2007 22:19:20 +0100 (CET)) Subject: Re: [Patch]: Little Cleanup Reply-to: Eli Zaretskii References: <45E7CC17.5040304@de.ibm.com> <45E93AE5.5050704@portugalmail.pt> <45EBB15E.4000602@de.ibm.com> <200703052119.l25LJKVw021917@brahms.sibelius.xs4all.nl> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00049.txt.bz2 > Date: Mon, 5 Mar 2007 22:19:20 +0100 (CET) > From: Mark Kettenis > CC: deuling@de.ibm.com, pedro_alves@portugalmail.pt, > gdb-patches@sourceware.org > > > > I thought we agreed about adding a comment here, something like: > > > > /* insert_breakpoints returns non-zero if it fails to insert the > > breakpoints. */ > > Adding this sort of comments at all call sites of such functions is > really silly. I don't see anything silly about making the code clearer.