From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5821 invoked by alias); 26 Sep 2005 03:46:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5807 invoked by uid 22791); 26 Sep 2005 03:46:13 -0000 Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 26 Sep 2005 03:46:13 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-56-213.inter.net.il [80.230.56.213]) by nitzan.inter.net.il (MOS 3.6.5-GR) with ESMTP id BNH05253 (AUTH halo1); Mon, 26 Sep 2005 06:46:09 +0300 (IDT) Date: Mon, 26 Sep 2005 03:46:00 -0000 Message-Id: From: Eli Zaretskii To: Dave Murphy CC: gdb-patches@sources.redhat.com In-reply-to: <4337317B.3050300@ntlworld.com> (message from Dave Murphy on Mon, 26 Sep 2005 00:23:39 +0100) Subject: Re: [patch] Build arm-elf-gdb on mingw host Reply-to: Eli Zaretskii References: <4337317B.3050300@ntlworld.com> X-SW-Source: 2005-09/txt/msg00214.txt.bz2 > Date: Mon, 26 Sep 2005 00:23:39 +0100 > From: Dave Murphy > > When building the bfd/doc directory under mingw/msys chew.c converts > line endings to crlf. I've patched so the files are read as binary, > preventing this conversion. Why? What's wrong with having the output from chew have CRLF line endings on Windows? > SIGTRAP isn't defined in the MinGW headers, I patched remote-sim.c to > define this if it's not defined. I don't think this is a good idea. It is much better (and widely practiced) to #ifdef away portions of code that use SIGTRAP, like this: #ifdef SIGTRAP ... code that depends on SIGTRAP ... #endif