From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-50077-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10696 invoked by alias); 3 Aug 2007 13:26:00 -0000
Received: (qmail 10688 invoked by uid 22791); 3 Aug 2007 13:25:59 -0000
X-Spam-Check-By: sourceware.org
Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (213.8.233.22)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Aug 2007 13:25:56 +0000
Received: from HOME-C4E4A596F7 (IGLD-83-130-197-78.inter.net.il [83.130.197.78]) 	by nitzan.inter.net.il (MOS 3.7.3a-GA) 	with ESMTP id HKX99117 (AUTH halo1); 	Fri, 3 Aug 2007 16:26:02 +0300 (IDT)
Date: Fri, 03 Aug 2007 13:26:00 -0000
Message-Id: <usl70bvhd.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Markus Deuling <deuling@de.ibm.com>
CC: gdb-patches@sourceware.org, uweigand@de.ibm.com
In-reply-to: <46B3271B.1010203@de.ibm.com> (message from Markus Deuling on 	Fri, 03 Aug 2007 15:01:15 +0200)
Subject: Re: [rfc] [01/12] Get rid of current_gdbarch in aix-thread.c
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <46B31B17.6070204@de.ibm.com> <utzrgbx8p.fsf@gnu.org> <46B3271B.1010203@de.ibm.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-08/txt/msg00050.txt.bz2

> Date: Fri, 03 Aug 2007 15:01:15 +0200
> From: Markus Deuling <deuling@de.ibm.com>
> CC: gdb-patches@sourceware.org, uweigand@de.ibm.com
> 
> >> 	* aix-thread.c (supply_gprs64, supply_fprs, supply_sprs64)
> >> 	(supply_sprs32, fetch_regs_user_thread, fetch_regs_kernel_thread)
> >> 	(fill_gprs64, fill_gprs32, fill_fprs, fill_sprs64, fill_sprs32)
> >> 	(store_regs_user_thread, store_regs_kernel_thread): Use FRAME or
> >> 	REGCACHE to recognize current architecture.
> > 
> > What are FRAME and REGCACHE here?  They are not variables nor macros
> > seen in the patches.
> > 
> 
> sorry for being unprecise. What I meant is for example REGCACHE parameter here:
> 
> static void
> supply_gprs64 (struct regcache *regcache, uint64_t *vals)
> {
>   struct gdbarch_tdep *tdep = gdbarch_tdep (current_gdbarch);
>   int regno;
> 
> So current_gdbarch can be replaced by get_regcache_arch (regcache).

In that case, I'd prefer to rephrase the log entry as follows:

   Use get_regcache_arch or get_frame_arch to get at the current
   architecture by regcache or by frame, respectively.