From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-59734-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32503 invoked by alias); 7 Nov 2008 14:49:16 -0000
Received: (qmail 32421 invoked by uid 22791); 7 Nov 2008 14:49:15 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout4.012.net.il (HELO mtaout4.012.net.il) (84.95.2.10)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 07 Nov 2008 14:48:31 +0000
Received: from conversion-daemon.i_mtaout4.012.net.il by i_mtaout4.012.net.il (HyperSendmail v2004.12) id <0K9Y00000W87EE00@i_mtaout4.012.net.il> for gdb-patches@sourceware.org; Fri, 07 Nov 2008 16:50:13 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.241.172]) by i_mtaout4.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K9Y00DZHX7O8471@i_mtaout4.012.net.il>; Fri, 07 Nov 2008 16:50:13 +0200 (IST)
Date: Fri, 07 Nov 2008 14:49:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Process record and replay, 10/10
In-reply-to: <daef60380811052352r48807fc1sbbeeb0f34c035217@mail.gmail.com>
X-012-Sender: halo1@inter.net.il
To: teawater <teawater@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uskq3sibo.fsf@gnu.org>
References: <daef60380811052352r48807fc1sbbeeb0f34c035217@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00125.txt.bz2

> Date: Thu, 6 Nov 2008 15:52:30 +0800
> From: teawater <teawater@gmail.com>
> 
> This patch add document for process record and replay.
> 
> 2008-11-06  Hui Zhu  <teawater@gmail.com>
> 
> 	* gdb.texinfo: Add documentation for process record and replay.

Thanks.  I have a couple of comments.

> +@chapter Recording programs running message and replay it

I don't understand this phrase.  What did you want to say? what does
the word "message" have to do with this feature?

> +@kindex target record
> +@kindex record
> +@kindex rec
> +@item target record
> +This a standard command to start process record and replay target.
> +Process record and replay target can only debug a process that already
> +running.  Therefore you need to first start the process @code{run},
> +and then start the recording @code{record}.

Is the command "target record" or just "record"? or is the latter an
alias of the former?  We need to explain all this in the manual,
because the @item says "target record", while in the last sentence
above you say that the command is "record"

Other than that, this part of the patch is okay.

By the way, I think we need a NEWS entry for this feature.