From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-60087-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30961 invoked by alias); 18 Nov 2008 20:02:57 -0000
Received: (qmail 30901 invoked by uid 22791); 18 Nov 2008 20:02:57 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Nov 2008 20:02:17 +0000
Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KAJ00K00NYTAC00@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Tue, 18 Nov 2008 22:04:10 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.205.49]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KAJ00B6GP2XQZ90@i-mtaout1.012.net.il>; Tue, 18 Nov 2008 22:04:09 +0200 (IST)
Date: Wed, 19 Nov 2008 00:44:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 4/4] catch syscall -- try 3 -- Build system, documentation 	and testcase
In-reply-to: <1226987134.5454.37.camel@miki>
X-012-Sender: halo1@inter.net.il
To: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uskpols50.fsf@gnu.org>
References: <1226987134.5454.37.camel@miki>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00478.txt.bz2

> From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@linux.vnet.ibm.com>
> Date: Tue, 18 Nov 2008 03:45:34 -0200
> 
> +if @var{GDBN} does not fully support your system's list of system
      ^^^^^^^^^^
@value{GDBN}

> +(gdb) catch syscall
> +Catchpoint 1 (syscall)

That's a strange wording.  Wouldn't it be better to say

  Catchpoint 1 (any syscall)

?

Also, please use (@value{GDBP}) (P, not N) instead of a literal (gdb),
when you show a prompt.

> +Catchpoint 1 (calling syscall 'close'), 0xffffe424 in __kernel_vsyscall ()

I'd prefer

   Catchpoint 1 (call to syscall 'close')

> +(gdb) catch syscall chroot
> +Catchpoint 1 (syscalls 'chroot')

"syscalls 'chroot'" (in plural) or "syscall 'chroot'" (single)?

> +(gdb) catch syscall 252
> +Catchpoint 1 (syscalls 'exit_group')

The translation to a mnemonic name will only happen if the XML file
does know about the syscall, right?  What if it doesn't?

Otherwise, the doco patch is approved.

Thanks.