From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30717 invoked by alias); 12 Aug 2008 18:18:44 -0000 Received: (qmail 30707 invoked by uid 22791); 12 Aug 2008 18:18:43 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout2.012.net.il (HELO mtaout2.012.net.il) (84.95.2.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Aug 2008 18:17:40 +0000 Received: from HOME-C4E4A596F7 ([84.229.211.50]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K5I009CA2TXL441@i_mtaout2.012.net.il> for gdb-patches@sourceware.org; Tue, 12 Aug 2008 21:17:58 +0300 (IDT) Date: Tue, 12 Aug 2008 18:18:00 -0000 From: Eli Zaretskii Subject: Re: Add a third mode to "breakpoints always-inserted", and make it the default In-reply-to: <200808120034.25338.pedro@codesourcery.com> X-012-Sender: halo1@inter.net.il To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <200808120034.25338.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00319.txt.bz2 > From: Pedro Alves > Date: Tue, 12 Aug 2008 00:34:24 +0100 > > So, this patch changes the "set breakpoints always-inserted" setting to > be a three-state. on and off, the same as before, and a new mode, > "follow-non-stop". How about calling this state "auto"? > In the latter mode, GDB will behave as "on", if > we're in non-stop mode, and as "off" if we're in all-stop mode. I think _behave_ as "on" is not a good idea. I suggest that it actually _set_ the option "on". That way, code elsewhere will need only to look at a single option, and won't need to know that if the value is follow-non-stop, it needs to check another flag. > +This is the default mode. If gdb is controlling the inferior in > +non-stop mode (@pxref{Non-Stop Mode}), gdb behaves as if > +always-inserted mode is on. If gdb is controlling the inferior in > +all-stop mode, gdb behaves as if always-inserted mode is off. We don't use a literal "gdb" in the manual, we use "@value{GDBN}". Also, it would be helpful to have an index entry here, something like @cindex non-stop mode, and @code{breakpoint always-inserted}