From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 860 invoked by alias); 14 Aug 2008 19:21:27 -0000 Received: (qmail 851 invoked by uid 22791); 14 Aug 2008 19:21:26 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 14 Aug 2008 19:20:46 +0000 Received: from HOME-C4E4A596F7 ([84.229.211.50]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K5L00BYEV2P8I80@i-mtaout7.012.net.il> for gdb-patches@sources.redhat.com; Thu, 14 Aug 2008 22:20:50 +0300 (IDT) Date: Thu, 14 Aug 2008 19:21:00 -0000 From: Eli Zaretskii Subject: Re: Fix python indented multi-line commands In-reply-to: <1218686123.8263.18.camel@localhost.localdomain> X-012-Sender: halo1@inter.net.il To: Thiago Jung Bauermann Cc: gdb-patches@sources.redhat.com, drow@false.org Reply-to: Eli Zaretskii Message-id: References: <1218686123.8263.18.camel@localhost.localdomain> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00376.txt.bz2 > From: Thiago Jung Bauermann > Cc: gdb-patches@sources.redhat.com, Daniel Jacobowitz > Date: Thu, 14 Aug 2008 00:55:23 -0300 > > > Please don't call variables by mysterious names such as > > "special_processing". Please give that variable a meaningful name > > that would explain the purpose of this flag even without reading the > > code of the callers of this function. > > I agree. The argument has two effects though (stripping of leading > whitespace, and recognizing GDB control commands), so I had some > difficulty in finding a meaningful name for it. That's why I left it > with that one. It is now called parse_input, what do you think? "parse_commands"? Or maybe "only_end_cmd" (and reverse the tests)?