Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Doug Evans <dje@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: RFC: add ability to "source" Python code
Date: Mon, 09 Feb 2009 04:09:00 -0000	[thread overview]
Message-ID: <ur628s156.fsf@gnu.org> (raw)
In-Reply-To: <e394668d0902081752y6cf99c53tc230b1f115da15a2@mail.gmail.com>

> Date: Sun, 8 Feb 2009 17:52:46 -0800
> From: Doug Evans <dje@google.com>
> Cc: tromey@redhat.com, gdb-patches@sourceware.org
> 
> On Sat, Feb 7, 2009 at 8:08 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > However, I don't think I like the idea of GDB barfing if Python
> > support is not compiled in.  I think it should simply try to interpret
> > the file as GDB scripting commands.
> 
> I 3/4 disagree.  :-)
> 
> In the case of "source -p foo", I disagree.  This is new functionality
> (*1), and silently (or otherwise) interpreting "source -p foo" as gdb
> scripts will lead to subsequent breakage if/when python support does
> get compiled in.  [That's 1/2 of the 3/4.]
> 
> In the case of "source foo.py" I sort of disagree (that's the other 1/4, fwiw).
> Technically speaking it's possible that some bloke out there has a
> foo.py script that actually is gdb commands, and forcing the script to
> be interpreted as python would break that.  It's seems really unlikely
> though.
> 
> Perhaps "source" could/should also take a -g option to force the
> script to be interpreted as gdb commands.  It mightn't be sufficient
> to justify breaking an existing "source foo.py" being interpreted as
> gdb commands (though I think it is), but it might be reasonable to add
> anyway.
> 
> [(*1): And if we're worried about breaking existing usage, do we also
> need to worry about someone with a script named "-p foo.gdb"?

To clarify, I think "source" without Python compiled should behave
exactly as it did before this patch: treat foo.py as any other file
name and treat -p as it does today (i.e. source "-p foo.gdb" if it
exists).

Yes, this is called "backward compatibility".  It just could be that
one reason why someone configures GDB without Python is that they
don't want this incompatible change.


  reply	other threads:[~2009-02-09  4:09 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-08  1:16 Tom Tromey
2009-02-08  1:34 ` Tom Tromey
2009-02-08  4:10   ` Eli Zaretskii
2009-02-08  4:08 ` Eli Zaretskii
2009-02-09  1:53   ` Doug Evans
2009-02-09  4:09     ` Eli Zaretskii [this message]
2009-02-10  1:37       ` Tom Tromey
2009-02-10  1:30     ` Tom Tromey
2009-02-09  1:35 ` Doug Evans
2009-02-10  0:00 ` Pedro Alves
2009-02-10  1:29   ` Tom Tromey
2009-02-10  2:36     ` Pedro Alves
2009-02-10  3:48       ` Daniel Jacobowitz
2009-02-10  9:34         ` Eli Zaretskii
2009-02-10 11:58           ` Thiago Jung Bauermann
2009-02-10 17:04             ` Tom Tromey
2009-02-11  2:25               ` Paul Pluzhnikov
2009-02-11  6:09               ` Joel Brobecker
2009-02-11 19:51                 ` Tom Tromey
2009-02-11 20:21                   ` Eli Zaretskii
2009-02-11 20:39                     ` Joel Brobecker
2009-02-11 21:06                       ` Eli Zaretskii
2009-02-11 21:26                         ` Matt Rice
2009-02-11 21:49                           ` Eli Zaretskii
2009-02-11 21:55                             ` Eli Zaretskii
2009-02-11 22:01                         ` Joel Brobecker
2009-02-12  3:59                           ` Eli Zaretskii
2009-02-12  6:27                             ` Joel Brobecker
2009-02-12 20:32                               ` Thiago Jung Bauermann
2009-02-12 22:38                               ` Eli Zaretskii
2009-02-13  8:42                                 ` Joel Brobecker
2009-02-13 15:23                                   ` Eli Zaretskii
2009-02-17  0:58                                     ` Joel Brobecker
2009-02-17  5:54                                       ` Eli Zaretskii
2009-02-17 20:37                                         ` Tom Tromey
2009-02-19 21:45                                           ` Joel Brobecker
2009-06-01  3:57                                             ` Thiago Jung Bauermann
2009-06-01  5:05                                               ` Paul Pluzhnikov
2009-06-01 15:33                                                 ` Eli Zaretskii
2009-06-01 15:46                                               ` Eli Zaretskii
2009-06-01 17:54                                                 ` Thiago Jung Bauermann
2009-06-10 23:10                                               ` Tom Tromey
2009-06-11 14:19                                                 ` Joel Brobecker
2009-07-03  7:21                                                 ` Paul Pluzhnikov
2010-01-15  7:21                                               ` Joel Brobecker
2010-01-15  9:13                                                 ` Joel Brobecker
2010-01-15 18:03                                                   ` Tom Tromey
2010-01-18  6:33                                                     ` Joel Brobecker
2010-01-18 17:48                                                       ` Eli Zaretskii
2010-01-19 10:32                                                         ` Joel Brobecker
2009-02-11 20:43                     ` Daniel Jacobowitz
2009-02-11 21:08                       ` Eli Zaretskii
2009-02-11 21:16                         ` Daniel Jacobowitz
2009-02-11 21:46                           ` Eli Zaretskii
2009-02-11 20:54                     ` Tom Tromey
2009-02-11 21:11                       ` Eli Zaretskii
2009-02-11 20:46                   ` Joel Brobecker
2009-02-11 20:58                     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ur628s156.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox