From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17870 invoked by alias); 26 Oct 2007 09:44:44 -0000 Received: (qmail 17860 invoked by uid 22791); 26 Oct 2007 09:44:44 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (213.8.233.22) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 26 Oct 2007 09:44:41 +0000 Received: from HOME-C4E4A596F7 (IGLD-83-130-4-91.inter.net.il [83.130.4.91]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id IDL26439 (AUTH halo1); Fri, 26 Oct 2007 11:41:58 +0200 (IST) Date: Fri, 26 Oct 2007 12:05:00 -0000 Message-Id: From: Eli Zaretskii To: "Pierre Muller" CC: gdb-patches@sourceware.org, drow@false.org In-reply-to: <002601c817a3$fcdf7470$f69e5d50$@u-strasbg.fr> (muller@ics.u-strasbg.fr) Subject: Re: [RFC] Doschk.c and update-web-ari changes Reply-to: Eli Zaretskii References: <002601c817a3$fcdf7470$f69e5d50$@u-strasbg.fr> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00708.txt.bz2 > From: "Pierre Muller" > Cc: "'Eli Zaretskii'" , > > Date: Fri, 26 Oct 2007 09:44:06 +0200 > > Here are the changes I made to doschk.c > and update-web-ari to get a better result. > > The changes inside doschk.c are mainly aimed > to facilitate the correct handling by update-web-ari. FWIW, I don't think it's a good idea to change doschk.c for this. This program is widely available and used, so it's better to modify our script to use doschk's output as-is; otherwise everyone will need to install a patched doschk to get things right, and also we will need to remember to keep a patched version where the ari script is run. > As you will see, lots of these duplicates are > in directories that will probably not be in the DJGPP > gdb sources. If you want to rely on the fact that some directories are omitted from the DJGPP source zip files, then I don't think it's right to do so, because the file-name conflicts are already resolved in those zip files anyhow. What is important is that a DJGPP user could unpack the official GDB tarball using djunpack.bat without any problems. This means that file-name conflicts in the official GDB tarball should be resolved either by renaming files or by adding lines to fnchange.lst. > * doschk.c (fill_ent): Use lowercase characters. Why? > (display_problems): Also proint relative path with dos_name. ^^^^^^ You meant "print".