From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-57706-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25300 invoked by alias); 6 Aug 2008 18:24:00 -0000
Received: (qmail 25072 invoked by uid 22791); 6 Aug 2008 18:23:57 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 06 Aug 2008 18:23:18 +0000
Received: from HOME-C4E4A596F7 ([77.126.7.152]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K5600I04Z0WV251@i_mtaout5.012.net.il> for gdb-patches@sourceware.org; Wed, 06 Aug 2008 21:22:09 +0300 (IDT)
Date: Wed, 06 Aug 2008 18:24:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA][patch 1/9] Initial Python support, patch du jour
In-reply-to: <1218000867.4534.56.camel@localhost.localdomain>
X-012-Sender: halo1@inter.net.il
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: tromey@redhat.com, drow@false.org, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <upromj96l.fsf@gnu.org>
References: <20080429155212.444237503@br.ibm.com> <20080429155304.288626880@br.ibm.com> <20080528205921.GA2969@caradoc.them.org> <20080615181833.uxmo25mg0kko40kw@imap.linux.ibm.com> <1216107418.14956.27.camel@localhost.localdomain> <m3od4z3w0t.fsf@fleche.redhat.com> <m3k5fl3ncy.fsf@fleche.redhat.com> <1216245620.12209.18.camel@localhost.localdomain> <20080718195010.GA14356@caradoc.them.org> <1216653969.31797.6.camel@localhost.localdomain> <uwsj84wx5.fsf@gnu.org> <m3prp0efvr.fsf@fleche.redhat.com> <uhcac4iut.fsf@gnu.org> <1217909927.7578.61.camel@localhost.localdomain> <uy73bjpo6.fsf@gnu.org> <1218000867.4534.56.camel@localhost.localdomain>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-08/txt/msg00129.txt.bz2

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: tromey@redhat.com, drow@false.org, gdb-patches@sourceware.org
> Date: Wed, 06 Aug 2008 02:34:27 -0300
> 
> +Evaluate @var{command}, a string, as a @value{GDBN} CLI command.
> +If a GDB exception happens while @var{command} runs, it is
> +translated as described above.

There's no description of exceptions translation in this node, so
"above" is not really true.  If the description is in another node,
please use a cross-reference to point there.

> +@defun get_parameter parameter
> +Find the value of a @value{GDBN} parameter.  @var{parameter} is a
   ^^^^^^^^^^^^^^
I think "return the value" is better here.

Otherwise, the patches for the manual are okay with me; thanks.