From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16366 invoked by alias); 21 Jan 2009 19:03:48 -0000 Received: (qmail 16098 invoked by uid 22791); 21 Jan 2009 19:03:47 -0000 X-SWARE-Spam-Status: No, hits=1.7 required=5.0 tests=AWL,BAYES_00,BOTNET,J_CHICKENPOX_37,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Jan 2009 19:03:40 +0000 Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KDU002004PVLY00@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Wed, 21 Jan 2009 21:03:36 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.60.234]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KDU00DSG4XY6OX0@i-mtaout1.012.net.il>; Wed, 21 Jan 2009 21:03:35 +0200 (IST) Date: Wed, 21 Jan 2009 19:03:00 -0000 From: Eli Zaretskii Subject: Re: Add support for --with-system-gdbinit In-reply-to: <20090121105348.GD148@adacore.com> To: Jerome Guitton Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <20090114135619.GA24456@caradoc.them.org> <20090114194922.GA13339@caradoc.them.org> <20090119141053.GE45099@adacore.com> <20090121105348.GD148@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00439.txt.bz2 > Date: Wed, 21 Jan 2009 11:53:48 +0100 > From: Jerome Guitton > Cc: gdb-patches@sourceware.org > > Index: doc/gdb.texinfo > =================================================================== > RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v > retrieving revision 1.545 > diff -u -p -r1.545 gdb.texinfo > --- doc/gdb.texinfo 14 Jan 2009 11:47:07 -0000 1.545 > +++ doc/gdb.texinfo 21 Jan 2009 10:52:02 -0000 This part is approved, with a few minor comments: > +Reads the system-wide @dfn{init file} (if @option{--with-system-gdbinit} was There's no need to use @dfn for the same term more than once. Once the term is introduced, you should use it without the @dfn markup. > +@value{GDBN} can be configured to have a system-wide @dfn{init file}; Likewise. > +If the default location of this init file contains the prefix, ^^^^^^^^^^ It took me a while to understand what is meant by "the prefix". I think we should explain this explicitly, as referring to $prefix. > +it will be subject to relocation. Suppose that @value{GDBN} has been ^^ Two spaces after a period that ends a sentence, please. > +configured with @kbd{--prefix=$prefix} and > +@kbd{--with-system-gdbinit=$prefix/etc/gdbinit}; if @value{GDBN} is It is better to use @option here, not @kbd, since you are not describing keyboard input. > +installed somewhere else (say: in @file{$install/bin}), the system > +init file will be looked for relatively to this new location: in our > +case, it will be @file{$install/bin/../etc/gdbinit}. This is a bit confusing, because you say if @value{GDBN} is installed somewhere else (say: in @file{$install/bin}) This subtly introduces the bin/ subdirectory and requires the reader to know that "@value{GDBN} is installed" refers to the GDB _binary_, not to GDB as a package. The latter is, of course, installed in $prefix and moved to $install. Can you rewrite this bit to explain that GDB is moved from $prefix to $install, and then the system-wide init file is looked for as $install/etc/gdbinit instead of $prefix/etc/gdbinit? > +At the contrary, if the default location does not contain the prefix, ^^^^^^^^^^^^^^^ "By contrast" is better here. > +it will not be relocated. E.g.@: if @value{GDBN} has been configured with ^^ Two spaces. Thanks.