From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31809 invoked by alias); 2 Feb 2009 21:04:43 -0000 Received: (qmail 31801 invoked by uid 22791); 2 Feb 2009 21:04:42 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout2.012.net.il (HELO mtaout2.012.net.il) (84.95.2.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Feb 2009 21:04:36 +0000 Received: from conversion-daemon.i_mtaout2.012.net.il by i_mtaout2.012.net.il (HyperSendmail v2004.12) id <0KEG00J00I7SO100@i_mtaout2.012.net.il> for gdb-patches@sourceware.org; Mon, 02 Feb 2009 23:04:55 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.228.158.130]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KEG000QSIK2DUD3@i_mtaout2.012.net.il>; Mon, 02 Feb 2009 23:04:51 +0200 (IST) Date: Mon, 02 Feb 2009 21:04:00 -0000 From: Eli Zaretskii Subject: Re: [1/2] Inspect extra signal information In-reply-to: <200902021652.28152.pedro@codesourcery.com> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <200901121846.51709.pedro@codesourcery.com> <200901121852.06948.pedro@codesourcery.com> <200902021652.28152.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00040.txt.bz2 > From: Pedro Alves > Date: Mon, 2 Feb 2009 16:52:27 +0000 > > > I think this introduces a general-purpose infrastructure that must be > > documented in gdbint.texinfo. > > > > I'm taking a stab at this. Thanks! > I don't see struct value documented in > the internals manual though. What kind of detail do you require here? Exactly the kind you described. > I'm thinking of adding a "Values" section somewhere, don't know > where yet. The place doesn't matter much, since the internals manual is "work in progress", and looks more like a car crash than a concise document. > @item @code{lval_computed} > > These are values with arbitrary functions to handle reads and writes, Please lose the empty line between the @item and its description. > and "copy operators" and "destructors". They allow creating Please use ``this kind of quoting'' in Texinfo, not "this kind". > described by the @code{struct lval_funcs} struture declared in ^^^^^^^^ A typo. > @file{value.h} to the @code{allocate_computed_value} function. An What does it mean "declared in value.h to the allocate_computed_value function"? Perhaps add a few words describing `struct lval_funcs', or maybe just showing a simple example would be enough. A couple of index entries for this section will also help. Thanks again for working on this.