Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Blandy <jimb@red-bean.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Formatting of packet descriptions in GDB manual
Date: Wed, 16 Nov 2005 07:21:00 -0000	[thread overview]
Message-ID: <umzk56p9g.fsf@gnu.org> (raw)
In-Reply-To: <8f2776cb0511152152p85abe3pa7ad547043c53c0a@mail.gmail.com> (message from Jim Blandy on Tue, 15 Nov 2005 21:52:06 -0800)

> Date: Tue, 15 Nov 2005 21:52:06 -0800
> From: Jim Blandy <jimb@red-bean.com>
> 
> Here's a patch that implements the formatting changes to the
> description of the remote protocol packets we've been discussing on
> gdb@.
> 
> This uses @code for the packet templates, even though in my last
> message there I said I thought @samp was more appropriate; @code is
> what I've got right now, and I didn't want to go and change everything
> twice if the conclusion was that @code was better.  But you can see
> what was done.

Thanks.  This is fine, but while at that, let's fix a few more minor
problems in the original text:

> ! @item b @var{baud}
>   @cindex @code{b} packet
> ! @strong{(deprecated)}
>   Change the serial line speed to @var{baud}.

I have a problem with this "(deprecated)" thing.  Can we simply add a
sentence saying this is deprecated in favor of whatever substitutions
we want people to use instead?

> ! @item i @r{[}@var{addr}@r{[},@var{nnn}@r{]]}
>   @anchor{cycle step packet}
>   @cindex @code{i} packet
> ! @strong{(draft)}
>   Step the remote target by a single clock cycle.  If @code{,}@var{nnn} is
>   present, cycle step @var{nnn} cycles.  If @var{addr} is present, cycle
>   step starting at that address.

Similarly here for "(draft)", but in this case I don't even understand
the implications of this packet being ``draft''.  Can we spell them
out in plain English?

(There are more "(deprecated)" and "(draft)" in that section.)

Several places use two or more @item's in consecutive lines, then
describe them both.  This is incorrect Texinfo: all but the first
@item should be @itemx.

> ! The @code{C}, @code{c}, @code{S}, @code{s} and @code{?} packets can
> ! receive any of the below as a reply.  In the case of the @code{C},
> ! @code{c}, @code{S} and @code{s} packets, that reply is only returned
> ! when the target halts.  In the below the exact meaning of ``signal
> ! number'' is poorly defined.

This ``signal number'' will look better in print and PDF if we use
@dfn{signal number}.

>   @var{AA} = two hex digit signal number; @var{n...} = register number
>   (hex), @var{r...}  = target byte ordered register contents, size defined
> ! by @code{DEPRECATED_REGISTER_RAW_SIZE}; @var{n...} = @code{thread},
>   @var{r...} = thread process ID, this is a hex integer; @var{n...} =
> ! (@code{watch} | @code{rwatch} | @code{awatch}, @var{r...} = data
>   address, this is a hex integer; @var{n...} = other string not starting
>   with valid hex digit.  @value{GDBN} should ignore this @var{n...},
>   @var{r...} pair and go on to the next.  This way we can extend the

I think this paragraph will read better if we replace the equals signs
with ``is'' or ``are'', as appropriate, or with some other English
construct.

Otherwise, this can go in, after you replace @code with @samp in the
@table lines, per your other message.

Thanks!


  reply	other threads:[~2005-11-16  7:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8f2776cb0511111624h4d646cd9i1f86824c5edc613f@mail.gmail.com>
     [not found] ` <ubr0q2vl9.fsf@gnu.org>
     [not found]   ` <8f2776cb0511120047y50b3a273pe17ddd5c53342be1@mail.gmail.com>
     [not found]     ` <u4q6h32bk.fsf@gnu.org>
     [not found]       ` <20051113171247.GA1945@nevyn.them.org>
     [not found]         ` <ur79ki4h7.fsf@gnu.org>
     [not found]           ` <20051114022955.GA10567@nevyn.them.org>
     [not found]             ` <uoe4nj1ih.fsf@gnu.org>
     [not found]               ` <20051114134924.GB21373@nevyn.them.org>
     [not found]                 ` <8f2776cb0511152147i4c24e43aue46a54332fd4c0f3@mail.gmail.com>
2005-11-16  7:17                   ` Jim Blandy
2005-11-16  7:21                     ` Eli Zaretskii [this message]
2005-11-16 14:34                       ` Jim Blandy
2005-11-16 19:37                         ` Nathan J. Williams
2005-11-16 19:53                           ` Daniel Jacobowitz
2005-11-16 19:50                         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=umzk56p9g.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox