From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32244 invoked by alias); 18 Feb 2006 11:47:31 -0000 Received: (qmail 32231 invoked by uid 22791); 18 Feb 2006 11:47:31 -0000 X-Spam-Check-By: sourceware.org Received: from gandalf.inter.net.il (HELO gandalf.inter.net.il) (192.114.186.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 18 Feb 2006 11:47:28 +0000 Received: from nitzan.inter.net.il (nitzan.inter.net.il [192.114.186.20]) by gandalf.inter.net.il (MOS 3.7.1-GA) with ESMTP id HXK05237; Sat, 18 Feb 2006 13:47:21 +0200 (IST) Received: from HOME-C4E4A596F7 (IGLD-84-228-139-42.inter.net.il [84.228.139.42]) by nitzan.inter.net.il (MOS 3.7.3-GA) with ESMTP id CSP70225 (AUTH halo1); Sat, 18 Feb 2006 13:47:19 +0200 (IST) Date: Sat, 18 Feb 2006 11:47:00 -0000 Message-Id: From: Eli Zaretskii To: Mark Kettenis CC: gdb-patches@sourceware.org, cygwin@cwilson.fastmail.fm In-reply-to: <200602181118.k1IBIwNC028708@elgar.sibelius.xs4all.nl> (message from Mark Kettenis on Sat, 18 Feb 2006 12:18:58 +0100 (CET)) Subject: Re: RFA: ensure binary objects opened in binary mode Reply-to: Eli Zaretskii References: <43F6473F.8030508@cwilson.fastmail.fm> <20060217234141.GA1918@trixie.casa.cgf.cx> <200602181118.k1IBIwNC028708@elgar.sibelius.xs4all.nl> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00346.txt.bz2 > Date: Sat, 18 Feb 2006 12:18:58 +0100 (CET) > From: Mark Kettenis > CC: gdb-patches@sourceware.org, cygwin@cwilson.fastmail.fm > > > Agreed. I think defs.h is a good place, do you agree? > > > Problem is that right now defs.h doesn't include (where I > expect O_BINARY to be defined on systems that have it). So we should > move that into fcntl.h as well You mean, include from defs.h, right? If so, I agree.