Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] [doc] thread-created/thread-exited
Date: Sat, 26 Apr 2008 19:05:00 -0000	[thread overview]
Message-ID: <umyngzcc8.fsf@gnu.org> (raw)
In-Reply-To: <200804262144.03702.vladimir@codesourcery.com>

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 26 Apr 2008 21:44:03 +0400
> 
> This patch documents the thread-create and thread-exited MI notification.
> It also fixes the terminology as bit -- the grammar say that out-of-band
> record is either async record or stream record, whereas the following docs
> first describe stream records and then talk about async records, but call
> them out-of-band.
> 
> OK?

Did you actually try to say "make info" after applying these patches?
Because I don't see how it could fly: you've modified the name of a
node, but did not change the corresponding item in the @menu of the
section of which "GDB/MI Out-of-band Records" was a subsection.  That
ought to trigger error messages from makeinfo.

> +The following is the list of possible async records

A colon at the end of this line, please.

>  @table @code
>  @item *stopped,reason="@var{reason}"
> +The target has stopped.
> +@item =thread-created,id="@var{id}"
> +@item =thread-exited,id="@var{id}"
> +A thread either was created, or has exited. The @var{id} field
> +contains the @var{GDBN} identifier of the thread.
>  @end table

Please leave an empty line before an @item line, otherwise it will
look ugly in print.  Also, you cannot have 2 @item lines in a row; all
but the first one must be @itemx, or else the formatting of the table
will come out wrong.  Finally, 2 spaces after a period that ends a
sentence, please.

> +For the @samp{*stopped} async record, the @var{reason} field can have
> +one of the following values:
>  
>  @table @code
>  @item breakpoint-hit

I'd put this right after the @item above that introduced the
`*stopped' record (yes, a table inside a table).  Didactically, it is
better to have related information close together, rather than apart.


  reply	other threads:[~2008-04-26 18:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26 17:54 Vladimir Prus
2008-04-26 19:05 ` Eli Zaretskii [this message]
2008-04-26 22:23   ` Vladimir Prus
2008-04-26 22:42     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=umyngzcc8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox